[GitHub] [pinot] chenboat commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

["chenboat (via GitHub)" <gi...@apache.org>]

chenboat commented on code in PR #10047:
URL: https://github.com/apache/pinot/pull/10047#discussion_r1197213067


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -395,6 +399,31 @@ protected void finishOperation() {
     }
   }
 
+  /**
+   * When TTL is enabled for upsert, this function is used to remove expired keys from the primary key indexes.
+   */
+  @Override
+  public void removeExpiredPrimaryKeys(Comparable timestamp) {
+    if (_upsertTTLConfig != null && _upsertTTLConfig.getTtlInMs() > 0) {

Review Comment:
   @deemoliu can you address this comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org