cleanup taglibs.jsp

[Allen Gilliland <Al...@Sun.COM>]

I've had this one on the radar for quite a while but never really wanted 
to do it because it'll require a bit of hacking on all the jsps, but 
since we are doing a bunch of cleanup work for 3.2 it seems appropriate.

I'd like to do 2 things ...

1. move the taglibs.jsp under WEB-INF/jsps like all the other jsps so 
that it's not out in the app context.  Doing this just means moving the 
file and updating all jsps which reference it with the new path.

2. remove the <html:xhtml> line and insert that line inside all of our 
actual struts jsps.  this is kind of a nit pick, but i don't think this 
line has anything to do with setting up the taglibs and imports and 
really it should be part of the actual struts jsps rather than hidden in 
this imported file.

pretty simple changes.  anyone object?

-- Allen

Re: cleanup taglibs.jsp

[Allen Gilliland <al...@sun.com>]

Matt Raible wrote:
> On 11/21/06, Allen Gilliland <Al...@sun.com> wrote:
>> I've had this one on the radar for quite a while but never really wanted
>> to do it because it'll require a bit of hacking on all the jsps, but
>> since we are doing a bunch of cleanup work for 3.2 it seems appropriate.
>>
>> I'd like to do 2 things ...
>>
>> 1. move the taglibs.jsp under WEB-INF/jsps like all the other jsps so
>> that it's not out in the app context.  Doing this just means moving the
>> file and updating all jsps which reference it with the new path.
>>
>> 2. remove the <html:xhtml> line and insert that line inside all of our
>> actual struts jsps.  this is kind of a nit pick, but i don't think this
>> line has anything to do with setting up the taglibs and imports and
>> really it should be part of the actual struts jsps rather than hidden in
>> this imported file.
> 
> This seems like a lot of work.  All this tag does is make the input
> tags XHTML-compliant.  Why would you want to define it in 40+ places
> rather than one?

Ah.  I thought it was doing something different.  That's cool then, we 
can just leave that one.

-- Allen

> 
> Matt
> 
>>
>> pretty simple changes.  anyone object?
>>
>> -- Allen
>>
> 
> 

Re: cleanup taglibs.jsp

[Matt Raible <mr...@gmail.com>]

On 11/21/06, Allen Gilliland <Al...@sun.com> wrote:
> I've had this one on the radar for quite a while but never really wanted
> to do it because it'll require a bit of hacking on all the jsps, but
> since we are doing a bunch of cleanup work for 3.2 it seems appropriate.
>
> I'd like to do 2 things ...
>
> 1. move the taglibs.jsp under WEB-INF/jsps like all the other jsps so
> that it's not out in the app context.  Doing this just means moving the
> file and updating all jsps which reference it with the new path.
>
> 2. remove the <html:xhtml> line and insert that line inside all of our
> actual struts jsps.  this is kind of a nit pick, but i don't think this
> line has anything to do with setting up the taglibs and imports and
> really it should be part of the actual struts jsps rather than hidden in
> this imported file.

This seems like a lot of work.  All this tag does is make the input
tags XHTML-compliant.  Why would you want to define it in 40+ places
rather than one?

Matt

>
> pretty simple changes.  anyone object?
>
> -- Allen
>


-- 
http://raibledesigns.com