You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:07:47 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38069: [SPARK-40628][SQL] Do not push complex left semi/anti join condition through project
dongjoon-hyun commented on code in PR #38069:
URL: https://github.com/apache/spark/pull/38069#discussion_r985997893
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushDownLeftSemiAntiJoin.scala:
##########
@@ -47,12 +47,17 @@ object PushDownLeftSemiAntiJoin extends Rule[LogicalPlan]
p.copy(child = Join(gChild, rightOp, joinType, joinCond, hint))
} else {
val aliasMap = getAliasMap(p)
- val newJoinCond = if (aliasMap.nonEmpty) {
- Option(replaceAlias(joinCond.get, aliasMap))
+ // Do not push complex join condition
Review Comment:
Could you elaborate a little more explicitly about the condition instead of too general term, `complex`, @wangyum ?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushDownLeftSemiAntiJoin.scala:
##########
@@ -47,12 +47,17 @@ object PushDownLeftSemiAntiJoin extends Rule[LogicalPlan]
p.copy(child = Join(gChild, rightOp, joinType, joinCond, hint))
} else {
val aliasMap = getAliasMap(p)
- val newJoinCond = if (aliasMap.nonEmpty) {
- Option(replaceAlias(joinCond.get, aliasMap))
+ // Do not push complex join condition
Review Comment:
Could you please elaborate a little more explicitly about the condition instead of too general term, `complex`, @wangyum ?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushDownLeftSemiAntiJoin.scala:
##########
@@ -47,12 +47,17 @@ object PushDownLeftSemiAntiJoin extends Rule[LogicalPlan]
p.copy(child = Join(gChild, rightOp, joinType, joinCond, hint))
} else {
val aliasMap = getAliasMap(p)
- val newJoinCond = if (aliasMap.nonEmpty) {
- Option(replaceAlias(joinCond.get, aliasMap))
+ // Do not push complex join condition
Review Comment:
This PR simply bans all aliases and seems to aim to allow a plain column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org