You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/28 23:22:58 UTC

[jira] [Commented] (BOOKKEEPER-907) for ReadLedgerEntriesCmd, EntryFormatter should be configurable and HexDumpEntryFormatter should be one of them

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783965#comment-15783965 ] 

ASF GitHub Bot commented on BOOKKEEPER-907:
-------------------------------------------

GitHub user reddycharan opened a pull request:

    https://github.com/apache/bookkeeper/pull/101

    BOOKKEEPER-907: EntryFormatter should be configur.

    for ReadLedgerEntriesCmd, EntryFormatter should
    be configurable and HexDumpEntryFormatter should
    be one of them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reddycharan/bookkeeper entryformatter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit 5a4ee88ed416d23dec50fa5a680c599caa47d717
Author: Charan Reddy Guttapalem <cg...@salesforce.com>
Date:   2016-12-28T23:05:04Z

    BOOKKEEPER-907: EntryFormatter should be configur.
    
    for ReadLedgerEntriesCmd, EntryFormatter should
    be configurable and HexDumpEntryFormatter should
    be one of them.

----


> for ReadLedgerEntriesCmd, EntryFormatter should be configurable and HexDumpEntryFormatter should be one of them
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-907
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-907
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Charan Reddy Guttapalem
>            Assignee: Charan Reddy Guttapalem
>            Priority: Minor
>
> In ReadLedgerEntriesCmd for printing the contents of the Entry, HexDumpFormat is used by default here, but whereas in ReadJournalCmd/ReadLogCmd StringEntryFormatter is used and it is configurable. We should add HexDumpEntryFormatter just like StringEntryFormatter and use the configured formatter for printing the entry.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)