You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/05/20 11:49:46 UTC

[GitHub] [druid] maytasm opened a new pull request #9900: Remove warn log message when metricSpec is explicitly set to empty

maytasm opened a new pull request #9900:
URL: https://github.com/apache/druid/pull/9900


   Remove warn log message when metricSpec is explicitly set to empty
   
   ### Description
   
   Saw the warning messages, `org.apache.druid.segment.indexing.DataSchema - No metricsSpec has been specified. Are you sure this is what you want?` in coordinator logs even when metricSpec is present but empty in the schema. It is annoying and fills up the logs. If metricSpec is present but is explicitly set to empty, then we do not need to show this warn log message. (After all the user did include and explicitly set metricSpec to empty in the ingestionSpec so they probably know what they are doing).
   
   This PR has:
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] maytasm closed pull request #9900: Remove warn log message when metricSpec is explicitly set to empty

Posted by GitBox <gi...@apache.org>.
maytasm closed pull request #9900:
URL: https://github.com/apache/druid/pull/9900


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org