You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by jv...@apache.org on 2001/12/31 16:30:19 UTC
cvs commit: jakarta-turbine-3/src/test/org/apache/turbine/pipeline TestPipelineMapper.java classic-turbine-pipeline.xml default-action-valve.xml default-target-valve.xml
jvanzyl 01/12/31 07:30:19
Added: src/test/org/apache/turbine/pipeline TestPipelineMapper.java
classic-turbine-pipeline.xml
default-action-valve.xml default-target-valve.xml
Log:
- Added a test for the mapping of a pipeline XML description to a pipeline
object using the mapper in stratum.
Revision Changes Path
1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/TestPipelineMapper.java
Index: TestPipelineMapper.java
===================================================================
package org.apache.turbine.pipeline;
/* ====================================================================
* The Apache Software License, Version 1.1
*
* Copyright (c) 2001 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
*
* 3. The end-user documentation included with the redistribution,
* if any, must include the following acknowledgment:
* "This product includes software developed by the
* Apache Software Foundation (http://www.apache.org/)."
* Alternately, this acknowledgment may appear in the software itself,
* if and wherever such third-party acknowledgments normally appear.
*
* 4. The names "Apache" and "Apache Software Foundation" and
* "Apache Turbine" must not be used to endorse or promote products
* derived from this software without prior written permission. For
* written permission, please contact apache@apache.org.
*
* 5. Products derived from this software may not be called "Apache",
* "Apache Turbine", nor may "Apache" appear in their name, without
* prior written permission of the Apache Software Foundation.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
* ====================================================================
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* <http://www.apache.org/>.
*/
import java.io.File;
import junit.framework.Test;
import junit.framework.TestCase;
import junit.framework.TestSuite;
import org.apache.stratum.xo.Mapper;
import org.apache.turbine.pipeline.TurbinePipeline;
/**
* Test Pipeline and valve definitions.
*
* @author <a href="mailto:jvanzyl@zenplex.com">Jason van Zyl</a>
* @version $Id: TestPipelineMapper.java,v 1.1 2001/12/31 15:30:19 jvanzyl Exp $
*/
public class TestPipelineMapper
extends TestCase
{
/**
* Test document which starts the whole mapping process.
*/
private static String TEST_DOCUMENT =
"src/test/org/apache/turbine/pipeline/classic-turbine-pipeline.xml";
/**
* Test class which is populated with the contents and
* specifications in the test document.
*/
private static String TEST_CLASS =
"org.apache.turbine.pipeline.TurbinePipeline";
/**
* Constructor
*/
public TestPipelineMapper(String testName)
{
super(testName);
}
/**
* Return the Test
*/
public static Test suite()
{
return new TestSuite(TestPipelineMapper.class);
}
/**
* Setup the test.
*/
public void setUp()
{
// Nothing done here yet.
}
/**
* Tear down the test.
*/
public void tearDown()
{
// Nothing to do here yet.
}
/**
* Test the mapping performed by the mapper.
*/
public void testPersonMapping()
{
try
{
Mapper m = new Mapper();
m.setDebug(true);
// We want to pull in valve definition by reference. This was
// originally setup for the Maven project object model where XML
// are located in different directories but I will change the
// default behaviour to look in the same directory first without
// having to define an inclusion rule. This can be done automatically.
// This rule just says that when we encounter a "valveDefinition"
// element to look in the same directory as the parent XML file
// for the description of the object to be consumed.
m.setInclusionRule("valveDefinition", ".");
TurbinePipeline p = (TurbinePipeline) m.map(TEST_DOCUMENT, TEST_CLASS);
// For our test so far we have a pipeline with two valve
// definitions. So lets make sure that the XML was consumed
// correctly and that our objects were created accordingly.
assertEquals("ClassicTurbinePipeline",p.getName());
assertEquals("DefaultActionValve",p.getValveDefinition(0).getName());
assertEquals("org.apache.turbine.pipeline.DefaultActionValve",
p.getValveDefinition(0).getClassName());
assertEquals("DefaultTargetValve",p.getValveDefinition(1).getName());
assertEquals("org.apache.turbine.pipeline.DefaultTargetValve",
p.getValveDefinition(1).getClassName());
}
catch (Exception e)
{
e.printStackTrace();
fail(e.getMessage());
}
}
}
1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/classic-turbine-pipeline.xml
Index: classic-turbine-pipeline.xml
===================================================================
<pipeline>
<name>ClassicTurbinePipeline</name>
<valveDefinitions>
<valveDefinition id="default-action-valve"/>
<valveDefinition id="default-target-valve"/>
</valveDefinitions>
</pipeline>
1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-action-valve.xml
Index: default-action-valve.xml
===================================================================
<valveDefinition>
<name>DefaultActionValve</name>
<className>org.apache.turbine.pipeline.DefaultActionValve</className>
</valveDefinition>
1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-target-valve.xml
Index: default-target-valve.xml
===================================================================
<valveDefinition>
<name>DefaultTargetValve</name>
<className>org.apache.turbine.pipeline.DefaultTargetValve</className>
</valveDefinition>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: Valve mappings
Posted by Jason van Zyl <jv...@zenplex.com>.
On 12/31/01 5:55 PM, "Daniel Rall" <dl...@finemaltcoding.com> wrote:
> I could really do without the additional indirection added by the
> separate XML files for each standard Valve implementation. They're
> just single XML elements, and do not need their own files. The amount
> of duplication introduced by inlining the elements is inconsequential,
> as they only consist of one piece of data--the class name--from which
> all other information can be divined.
You can specify them anyway you like all in one pipeline definition or by
inclusion. Works both ways. I just figured that if we started getting
comprehensive descriptions for the valves (for documentation generating
purposes) or if we add anything else then we could keep all that info in a
separate file. Plus if many pipelines start reusing different valves, which
I hope to be the case eventually, I was thinking that the separate XML files
would actually make it easier to reuse.
> Other than that, I love it. Thanks for doing the tests, Jason.
No problem, we should probably discuss how we want things to work then we
can divvy stuff up as I imagine it will only be the two of us for the next
little while, though I encourage anyone else to play.
I actually want to try and get the resources package into stratum so that we
can start pulling config info from the filesystem or the classpath (or a
datasource, url, or whatever) I taken pieces from the the resource
management system originally used in velocity and tried to clean it up a
bit.
But I guess we can talk about that next year! :-)
> Dan
>
>
> jvanzyl@apache.org writes:
>
>> jvanzyl 01/12/31 07:30:19
>>
>> Added: src/test/org/apache/turbine/pipeline TestPipelineMapper.java
>> classic-turbine-pipeline.xml
>> default-action-valve.xml default-target-valve.xml
>> Log:
>> - Added a test for the mapping of a pipeline XML description to a pipeline
>> object using the mapper in stratum.
>>
>> 1.1
>> jakarta-turbine-3/src/test/org/apache/turbine/pipeline/classic-turbine-pipeli
>> ne.xml
>>
>> Index: classic-turbine-pipeline.xml
>> ===================================================================
>> <pipeline>
>> <name>ClassicTurbinePipeline</name>
>> <valveDefinitions>
>> <valveDefinition id="default-action-valve"/>
>> <valveDefinition id="default-target-valve"/>
>> </valveDefinitions>
>> </pipeline>
>>
>>
>>
>> 1.1
>> jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-action-valve.x
>> ml
>>
>> Index: default-action-valve.xml
>> ===================================================================
>> <valveDefinition>
>> <name>DefaultActionValve</name>
>> <className>org.apache.turbine.pipeline.DefaultActionValve</className>
>> </valveDefinition>
>>
>>
>>
>> 1.1
>> jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-target-valve.x
>> ml
>>
>> Index: default-target-valve.xml
>> ===================================================================
>> <valveDefinition>
>> <name>DefaultTargetValve</name>
>> <className>org.apache.turbine.pipeline.DefaultTargetValve</className>
>> </valveDefinition>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
jvz.
Jason van Zyl
http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: Valve mappings
Posted by Daniel Rall <dl...@finemaltcoding.com>.
I could really do without the additional indirection added by the
separate XML files for each standard Valve implementation. They're
just single XML elements, and do not need their own files. The amount
of duplication introduced by inlining the elements is inconsequential,
as they only consist of one piece of data--the class name--from which
all other information can be divined.
Other than that, I love it. Thanks for doing the tests, Jason.
Dan
jvanzyl@apache.org writes:
> jvanzyl 01/12/31 07:30:19
>
> Added: src/test/org/apache/turbine/pipeline TestPipelineMapper.java
> classic-turbine-pipeline.xml
> default-action-valve.xml default-target-valve.xml
> Log:
> - Added a test for the mapping of a pipeline XML description to a pipeline
> object using the mapper in stratum.
>
> 1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/classic-turbine-pipeline.xml
>
> Index: classic-turbine-pipeline.xml
> ===================================================================
> <pipeline>
> <name>ClassicTurbinePipeline</name>
> <valveDefinitions>
> <valveDefinition id="default-action-valve"/>
> <valveDefinition id="default-target-valve"/>
> </valveDefinitions>
> </pipeline>
>
>
>
> 1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-action-valve.xml
>
> Index: default-action-valve.xml
> ===================================================================
> <valveDefinition>
> <name>DefaultActionValve</name>
> <className>org.apache.turbine.pipeline.DefaultActionValve</className>
> </valveDefinition>
>
>
>
> 1.1 jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-target-valve.xml
>
> Index: default-target-valve.xml
> ===================================================================
> <valveDefinition>
> <name>DefaultTargetValve</name>
> <className>org.apache.turbine.pipeline.DefaultTargetValve</className>
> </valveDefinition>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>