You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/28 21:38:52 UTC

[GitHub] szha commented on a change in pull request #11472: Add mirror to Gluon

szha commented on a change in pull request #11472: Add mirror to Gluon
URL: https://github.com/apache/incubator-mxnet/pull/11472#discussion_r198994899
 
 

 ##########
 File path: src/imperative/cached_op.cc
 ##########
 @@ -89,6 +89,22 @@ struct CachedOp::CachedOpState {
   std::multimap<size_t, NDArray> bwd_reuse_pool;
 };
 
+template<typename ValueType>
+inline ValueType get_node_attr(
+    const nnvm::Node& node,
+    const std::string& key, ValueType default_value) {
 
 Review comment:
   this looks generic enough to be in a utils file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services