[jira] [Resolved] (SPARK-23760) CodegenContext.withSubExprEliminationExprs should save/restore CSE state correctly

["Wenchen Fan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-23760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wenchen Fan resolved SPARK-23760.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 2.3.1
                   2.4.0

Issue resolved by pull request 20870
[https://github.com/apache/spark/pull/20870]

> CodegenContext.withSubExprEliminationExprs should save/restore CSE state correctly
> ----------------------------------------------------------------------------------
>
>                 Key: SPARK-23760
>                 URL: https://issues.apache.org/jira/browse/SPARK-23760
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.2.0, 2.2.1, 2.3.0
>            Reporter: Kris Mok
>            Assignee: Kris Mok
>            Priority: Major
>             Fix For: 2.4.0, 2.3.1
>
>
> There's a bug in {{CodegenContext.withSubExprEliminationExprs()}} that makes it effectively always clear the subexpression elimination state after it's called.
> The original intent of this function was that it should save the old state, set the given new state as current and perform codegen (invoke {{Expression.genCode()}}), and at the end restore the subexpression elimination state back to the old state. This ticket tracks a fix to actually implement the original intent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org