You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2023/11/21 19:40:40 UTC
[PR] HDDS-9745. Change IllegalStateException to IOException in SnapshotChainManager [ozone]
hemantk-12 opened a new pull request, #5652:
URL: https://github.com/apache/ozone/pull/5652
## What changes were proposed in this pull request?
As fix of HDDS-9199, exceptions in snapshot chain creation were changed IllegalStateException. We have seen couple of issues with this as in HDDS-9685 and HDDS-9745.
This change is to change unchecked `IllegalStateException` to checked `IOException` so that OM state machine can handle the exception properly and doesn't crash the system.
## What is the link to the Apache JIRA
[HDDS-9745](https://issues.apache.org/jira/browse/HDDS-9745)
## How was this patch tested?
Updated unit and integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9745. Change IllegalStateException to IOException in SnapshotChainManager [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on code in PR #5652:
URL: https://github.com/apache/ozone/pull/5652#discussion_r1401277963
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -300,7 +300,7 @@ private void removeSnapshotInfoFromSnapshotChainManager(
) {
try {
snapshotChainManager.deleteSnapshot(info);
- } catch (IllegalStateException exception) {
+ } catch (IOException exception) {
Review Comment:
Ah, I missed it. Removed.
Thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9745. Change IllegalStateException to IOException in SnapshotChainManager [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #5652:
URL: https://github.com/apache/ozone/pull/5652#issuecomment-1821869253
Thanks for the review @aswinshakil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9745. Change IllegalStateException to IOException in SnapshotChainManager [ozone]
Posted by "aswinshakil (via GitHub)" <gi...@apache.org>.
aswinshakil commented on code in PR #5652:
URL: https://github.com/apache/ozone/pull/5652#discussion_r1401273358
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -300,7 +300,7 @@ private void removeSnapshotInfoFromSnapshotChainManager(
) {
try {
snapshotChainManager.deleteSnapshot(info);
- } catch (IllegalStateException exception) {
+ } catch (IOException exception) {
Review Comment:
Do you want to remove this now that ISE is changed to IOException?
https://github.com/apache/ozone/blob/f8c42fa86724d5de0ee6511b2af8fb444c4611f4/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java#L194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9745. Change IllegalStateException to IOException in SnapshotChainManager [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #5652:
URL: https://github.com/apache/ozone/pull/5652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org