[GitHub] [iceberg] kbendick commented on a change in pull request #3986: Flink: Fix manifest location conflict when exist more than one committer on the same taskmanager

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3986:
URL: https://github.com/apache/iceberg/pull/3986#discussion_r794114085



##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/ManifestOutputFileFactory.java
##########
@@ -36,22 +36,24 @@
   private final Map<String, String> props;
   private final String flinkJobId;
   private final int subTaskId;
+  private final String operatorUniqueId;
   private final long attemptNumber;
   private final AtomicInteger fileCount = new AtomicInteger(0);
 
   ManifestOutputFileFactory(TableOperations ops, FileIO io, Map<String, String> props,
-                            String flinkJobId, int subTaskId, long attemptNumber) {
+                            String flinkJobId, int subTaskId, String operatorUniqueId, long attemptNumber) {
     this.ops = ops;
     this.io = io;
     this.props = props;
     this.flinkJobId = flinkJobId;
     this.subTaskId = subTaskId;
+    this.operatorUniqueId = operatorUniqueId;
     this.attemptNumber = attemptNumber;
   }
 
   private String generatePath(long checkpointId) {
-    return FileFormat.AVRO.addExtension(String.format("%s-%05d-%d-%d-%05d", flinkJobId, subTaskId,
-        attemptNumber, checkpointId, fileCount.incrementAndGet()));
+    return FileFormat.AVRO.addExtension(String.format("%s-%05d-%s-%d-%d-%05d", flinkJobId, subTaskId,

Review comment:
       +1. Little things like that to be more consistent make developer experience a lot smoother in the aggregate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org