You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/25 03:52:13 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2391: Add simple wm8994 codec driver
xiaoxiang781216 commented on a change in pull request #2391:
URL: https://github.com/apache/incubator-nuttx/pull/2391#discussion_r530090219
##########
File path: arch/arm/src/stm32f7/stm32f74xx75xx_rcc.c
##########
@@ -1005,3 +1006,44 @@ static inline void rcc_enableperipherals(void)
/****************************************************************************
* Public Functions
****************************************************************************/
+
+/****************************************************************************
+ * Name: stm32_rcc_dump_regs
+ *
+ * Description:
+ * Dump the contents of all rcc block registers
+ *
+ * Input Parameters:
+ * msg - Message to print before the register data
+ *
+ * Returned Value:
+ * None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_DEBUG_INFO
+void stm32_rcc_dump_regs(const char *msg)
Review comment:
@ChaochaoCui nobody call stm32_rcc_dump_regs, why not directly remove it?
##########
File path: boards/arm/stm32f7/stm32f746g-disco/include/board.h
##########
@@ -513,4 +521,31 @@
# define STM32_SDMMC_SDXFR_CLKDIV (2 << STM32_SDMMC_CLKCR_CLKDIV_SHIFT)
#endif
-#endif /* __BOARDS_ARM_STM32F7_STM32F746G_DISCO_INCLUDE_BOARD_H */
+/* SAI2 pinset */
+#if defined(CONFIG_STM32F7_SAI2) && defined(CONFIG_STM32F7_SAI2_A)
+#define GPIO_SAI2_SD_A GPIO_SAI2_SD_A_2
+#define GPIO_SAI2_FS_A GPIO_SAI2_FS_A_2
+#define GPIO_SAI2_SCK_A GPIO_SAI2_SCK_A_2
+#define GPIO_SAI2_MCLK_A GPIO_SAI2_MCLK_A_2
+#define GPIO_SAI2_SD_B GPIO_SAI2_SD_B_4
+
+#define DMACHAN_SAI2_A DMAMAP_SAI2_A
+#define DMACHAN_SAI2_B DMAMAP_SAI2_B
+
+#else
+
+#define GPIO_SAI1_SD_B GPIO_SAI1_SD_B_1
+#define DMACHAN_SAI1_B DMAMAP_SAI1_B
+
+#if 0
Review comment:
why skip the following defintion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org