You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/07 13:39:04 UTC
[GitHub] florianschmidt1994 commented on a change in pull request #6518:
[FLINK-10094][tests] Always backup config before running test
florianschmidt1994 commented on a change in pull request #6518: [FLINK-10094][tests] Always backup config before running test
URL: https://github.com/apache/flink/pull/6518#discussion_r208233155
##########
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##########
@@ -64,9 +64,7 @@ function run_test {
fi
fi
- if [[ ${exit_code} == 0 ]]; then
- cleanup
- else
+ if [[ ${exit_code} != 0 ]]; then
Review comment:
if there is only `exit "${exit_code}"` in there I think we can completely drop it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services