You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/09/08 23:00:57 UTC
[jira] Created: (WINK-173) Delay a few calls during initialization
unless absolutely required
Delay a few calls during initialization unless absolutely required
------------------------------------------------------------------
Key: WINK-173
URL: https://issues.apache.org/jira/browse/WINK-173
Project: Wink
Issue Type: Improvement
Components: Server
Affects Versions: 0.2
Reporter: Bryant Luk
Assignee: Bryant Luk
Fix For: 0.2
For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-173) Delay a few calls during
initialization unless absolutely required
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753154#action_12753154 ]
Hudson commented on WINK-173:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #139 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/139/])
Delay build of all HTTP request headers
See []
Skip path normalization if there are no evil paths
See []
Init the HashMap in AbstractRuntimeContext to 32
The context usually has more than 16 items in it
so a resize is always done anyway.
See []
> Delay a few calls during initialization unless absolutely required
> ------------------------------------------------------------------
>
> Key: WINK-173
> URL: https://issues.apache.org/jira/browse/WINK-173
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-173.patch
>
>
> For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-173) Delay a few calls during initialization
unless absolutely required
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-173:
----------------------------
Attachment: WINK-173.patch
The AbstractRuntimeContext change is as explained earlier.
The URI normalization is skipped if there are no tricky characters.
The HTTP headers cache is not completely built unless called for. For messages with headers that aren't required to be processed, this improves performance.
> Delay a few calls during initialization unless absolutely required
> ------------------------------------------------------------------
>
> Key: WINK-173
> URL: https://issues.apache.org/jira/browse/WINK-173
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-173.patch
>
>
> For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-173) Delay a few calls during
initialization unless absolutely required
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752798#action_12752798 ]
Bryant Luk commented on WINK-173:
---------------------------------
Doug Larson made a few profiles of the code and also reported on two other issues.
One is that the AbstractRuntimeContext's HashMap should be initialized to a value bigger than 16 since it always gets resized anyway.
Another is that UriPath normalization should be skipped if possible.
I'll attach a patch that details all these changes. There should be no functional changes between this code and the previous code.
> Delay a few calls during initialization unless absolutely required
> ------------------------------------------------------------------
>
> Key: WINK-173
> URL: https://issues.apache.org/jira/browse/WINK-173
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
>
> For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-173) Delay a few calls during initialization
unless absolutely required
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-173.
---------------------------
> Delay a few calls during initialization unless absolutely required
> ------------------------------------------------------------------
>
> Key: WINK-173
> URL: https://issues.apache.org/jira/browse/WINK-173
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-173.patch
>
>
> For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-173) Delay a few calls during initialization
unless absolutely required
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-173:
----------------------------
Patch Info: [Patch Available]
> Delay a few calls during initialization unless absolutely required
> ------------------------------------------------------------------
>
> Key: WINK-173
> URL: https://issues.apache.org/jira/browse/WINK-173
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-173.patch
>
>
> For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-173) Delay a few calls during initialization
unless absolutely required
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-173.
-----------------------------
Resolution: Fixed
Applied the patch.
Kudos to Doug Larson for pointing out the improvements.
> Delay a few calls during initialization unless absolutely required
> ------------------------------------------------------------------
>
> Key: WINK-173
> URL: https://issues.apache.org/jira/browse/WINK-173
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-173.patch
>
>
> For performance reasons, the HttpHeaders should not be built unless explicitly asked for.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.