You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/04/27 17:17:13 UTC
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17347
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
ORC-189 and ORC-666 added support for a new timestamp type
'TIMESTMAP WITH LOCAL TIMEZONE' to the Orc library.
This patch adds support for reading such timestamps with Impala.
These are UTC-normalized timestamps, therefore we convert them
to local timezone during scanning.
Testing:
* added test for CREATE TABLE LIKE ORC
* added scanner tests to test_scanners.py
Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
---
M be/src/exec/orc-column-readers.cc
M be/src/exec/orc-column-readers.h
M be/src/exec/orc-metadata-utils.cc
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/analysis/OrcSchemaExtractor.java
M java/shaded-deps/hive-exec/pom.xml
M testdata/data/README
A testdata/data/timestamp_with_local_timezone.orc
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test
A testdata/workloads/functional-query/queries/QueryTest/orc_timestamp_with_local_timezone.test
M tests/common/file_utils.py
M tests/metadata/test_ddl.py
M tests/query_test/test_scanners.py
13 files changed, 78 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/17347/1
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test
File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test:
http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test@132
PS1, Line 132: QUERY
> I think could be a CREATE section, then the RESULTS section would not be ne
We don't have CREATE_TABLE section when the .test file is executed by ImpalaTestSuite.run_test_case(). Only when the .test file is executed by TestShowCreateTable.__run_show_create_table_test_case().
Anyway, I've removed the unnecessary lines.
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 03 May 2021 12:09:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8676/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 03 May 2021 12:24:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 2: Code-Review+1
Hi Zoltan, sorry for my late reply, this patch LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 May 2021 11:39:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 07 May 2021 08:28:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 2:
No worries, thank you for the reply!
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 07 May 2021 08:28:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 May 2021 11:40:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
ORC-189 and ORC-666 added support for a new timestamp type
'TIMESTMAP WITH LOCAL TIMEZONE' to the Orc library.
This patch adds support for reading such timestamps with Impala.
These are UTC-normalized timestamps, therefore we convert them
to local timezone during scanning.
Testing:
* added test for CREATE TABLE LIKE ORC
* added scanner tests to test_scanners.py
Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Reviewed-on: http://gerrit.cloudera.org:8080/17347
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/orc-column-readers.cc
M be/src/exec/orc-column-readers.h
M be/src/exec/orc-metadata-utils.cc
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/analysis/OrcSchemaExtractor.java
M java/shaded-deps/hive-exec/pom.xml
M testdata/data/README
A testdata/data/timestamp_with_local_timezone.orc
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test
A testdata/workloads/functional-query/queries/QueryTest/orc_timestamp_with_local_timezone.test
M tests/common/file_utils.py
M tests/metadata/test_ddl.py
M tests/query_test/test_scanners.py
13 files changed, 76 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 1:
(1 comment)
Hi Zoltan, looks good to me, just left an observation on the test.
http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test
File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test:
http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test@132
PS1, Line 132: QUERY
I think could be a CREATE section, then the RESULTS section would not be needed here.
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 03 May 2021 07:48:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8650/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 17:34:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, wangsheng, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17347
to look at the new patch set (#2).
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
ORC-189 and ORC-666 added support for a new timestamp type
'TIMESTMAP WITH LOCAL TIMEZONE' to the Orc library.
This patch adds support for reading such timestamps with Impala.
These are UTC-normalized timestamps, therefore we convert them
to local timezone during scanning.
Testing:
* added test for CREATE TABLE LIKE ORC
* added scanner tests to test_scanners.py
Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
---
M be/src/exec/orc-column-readers.cc
M be/src/exec/orc-column-readers.h
M be/src/exec/orc-metadata-utils.cc
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/analysis/OrcSchemaExtractor.java
M java/shaded-deps/hive-exec/pom.xml
M testdata/data/README
A testdata/data/timestamp_with_local_timezone.orc
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test
A testdata/workloads/functional-query/queries/QueryTest/orc_timestamp_with_local_timezone.test
M tests/common/file_utils.py
M tests/metadata/test_ddl.py
M tests/query_test/test_scanners.py
13 files changed, 76 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/17347/2
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17347/1/tests/common/file_utils.py
File tests/common/file_utils.py:
http://gerrit.cloudera.org:8080/#/c/17347/1/tests/common/file_utils.py@34
PS1, Line 34: def create_table_from_orc(impala_client, unique_database, table_name):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/17347/1/tests/common/file_utils.py@39
PS1, Line 39: def create_table_from_file(impala_client, unique_database, table_name, file_format):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 17:18:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7124/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 07 May 2021 08:28:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Thanks Zoltan, LGTM!
http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test
File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test:
http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test@132
PS1, Line 132: QUERY
> We don't have CREATE_TABLE section when the .test file is executed by Impal
Ah, I see, thanks for the explanation, I thought these sections are more widespread.
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 03 May 2021 16:20:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9
Gerrit-Change-Number: 17347
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 07 May 2021 14:11:07 +0000
Gerrit-HasComments: No