[jira] [Commented] (SOLR-9952) S3BackupRepository

["Hrishikesh Gadre (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858169#comment-15858169 ] 

Hrishikesh Gadre commented on SOLR-9952:
----------------------------------------

[~alexey_suprun@epam.com] I reviewed your patch and it looks good. Just one minor suggestion - Instead of testing the core level backup/restore, we should test Solr cloud backup and restore (since it will test end-to-end scenario including core level backup). You may want to take a look at https://github.com/apache/lucene-solr/blob/0e0821fdc17052fa2b53ac7d3dd3038270d5ca64/solr/core/src/test/org/apache/solr/cloud/AbstractCloudBackupRestoreTestCase.java

BTW have you tried running the precommit for your patch? AFAIK for each new dependency you need to add LICENSE, NOTICE and sha files for precommit to succeed. Also we should check the license compatibility for each of these dependencies.

> S3BackupRepository
> ------------------
>
>                 Key: SOLR-9952
>                 URL: https://issues.apache.org/jira/browse/SOLR-9952
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mikhail Khludnev
>         Attachments: 0001-SOLR-9952-Added-dependencies-for-hadoop-amazon-integ.patch, 0002-SOLR-9952-Added-integration-test-for-checking-backup.patch, core-site.xml.template, Running Solr on S3.pdf
>
>
> I'd like to have a backup repository implementation allows to snapshot to AWS S3



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org