[GitHub] [iceberg] nastra edited a comment on pull request #2826: Build: Upgrade to Gradle 7.x

[GitBox <gi...@apache.org>]

nastra edited a comment on pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#issuecomment-884718583


   > Can you compare the generated pom's from the current build-files and see whether there are noteworthy differences to the pom's generated with this change? And whether the generated shadow-jar(s) still have the same content and pom's? Issues in there can be tricky to investigate later.
   
   Yes I did compare those already and I noticed that some runtime jars where slightly **bigger** on this branch because `exclude '...'` isn't properly working due to https://github.com/johnrengelman/shadow/issues/505. Pushed 4e33561fd7c256d7c42e06d93d7f7e64fd5d6877 that fixes this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org