You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/10/08 16:20:43 UTC
[Impala-ASF-CR] PROTOTYPE IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25074
Change subject: PROTOTYPE IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
PROTOTYPE IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
The cs join of tpcds-unmodified q78 had cs_item_sk=cs_item_sk instead
of cs_item_sk=ss_item_sk, unlike the TPC-DS specification and the
tpcds and tpcds_partitioned copies. The join then matched on year and
customer only and became many-to-many.
Since tpcds-unmodified is the performance test workload, this also
changes q78 baseline numbers.
Testing:
- No functional test runs this query (TestTpcdsUnmodified only runs
q31, q35a, q48, q59 and q89).
Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M testdata/workloads/tpcds-unmodified/queries/tpcds-q78.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/25074/1
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 17:15:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 20:59:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14245/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 16:23:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
The cs join of tpcds-unmodified q78 had cs_item_sk=cs_item_sk instead
of cs_item_sk=ss_item_sk, unlike the TPC-DS specification and the
tpcds and tpcds_partitioned copies. The join then matched on year and
customer only and became many-to-many.
Since tpcds-unmodified is the performance test workload, this also
changes q78 baseline numbers.
Testing:
- No functional test runs this query (TestTpcdsUnmodified only runs
q31, q35a, q48, q59 and q89).
Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Assisted-by: Claude Opus 5.5 (Claude Code)
Reviewed-on: http://gerrit.cloudera.org:8080/25074
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/tpcds-unmodified/queries/tpcds-q78.test
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 18:46:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
The cs join of tpcds-unmodified q78 had cs_item_sk=cs_item_sk instead
of cs_item_sk=ss_item_sk, unlike the TPC-DS specification and the
tpcds and tpcds_partitioned copies. The join then matched on year and
customer only and became many-to-many.
Since tpcds-unmodified is the performance test workload, this also
changes q78 baseline numbers.
Testing:
- No functional test runs this query (TestTpcdsUnmodified only runs
q31, q35a, q48, q59 and q89).
Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M testdata/workloads/tpcds-unmodified/queries/tpcds-q78.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/25074/2
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25074 )
Change subject: IMPALA-15526: Fix self-join typo in tpcds-unmodified q78
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/25074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5c6c11cc7badd70a1667527b98d3e71125fac8
Gerrit-Change-Number: 25074
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 17:14:18 +0000
Gerrit-HasComments: No