[jira] [Commented] (KAFKA-16190) Member should send full heartbeat when rejoining

["Lianet Magrans (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814133#comment-17814133 ] 

Lianet Magrans commented on KAFKA-16190:
----------------------------------------

Hey [~phuctran], regarding your first comment, we need to make sure we send every field when a member rejoins, as this is effectively a new member that is asking the broker to join a consumer group. Consider that fencing scenario I described in the task, when fenced, a member is not part of the group anymore and then rejoins as a new member, so it should send a full heartbeat to pass on all the info a new member requires.

That being said, this task was mainly to validate we were doing the rejoin heartbeat right, given that we were experiencing some issues with fenced members not rejoining properly, but we ended up finding a bug behind it with https://issues.apache.org/jira/browse/KAFKA-16215. I would suggest we follow-up that one and then re-consider this one. I could be missing something but maybe the issue we were after when reporting this one is the same bug fixed with 16215.

> Member should send full heartbeat when rejoining
> ------------------------------------------------
>
>                 Key: KAFKA-16190
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16190
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, consumer
>            Reporter: Lianet Magrans
>            Assignee: Quoc Phong Dang
>            Priority: Major
>              Labels: client-transitions-issues, kip-848-client-support, newbie
>             Fix For: 3.8.0
>
>
> The heartbeat request builder should make sure that all fields are sent in the heartbeat request when the consumer rejoins (currently the HeartbeatRequestManager request builder is reset on failure scenarios, which should cover the fence+rejoin sequence). 
> Note that the existing HeartbeatRequestManagerTest.testHeartbeatState misses this exact case given that it does explicitly change the subscription when it gets fenced. We should ensure we test a consumer that keeps it same initial subscription when it rejoins after being fenced.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)