You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by no...@apache.org on 2020/12/29 12:31:11 UTC

[buildstream] 17/19: Some tweaks

This is an automated email from the ASF dual-hosted git repository.

not-in-ldap pushed a commit to branch phil/ui-split-refactor
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit c2dafd2dc11af73838ae19e337f94687244f60cc
Author: Tom Pollard <to...@codethink.co.uk>
AuthorDate: Mon Jul 8 12:34:05 2019 +0100

    Some tweaks
---
 src/buildstream/_stream.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/buildstream/_stream.py b/src/buildstream/_stream.py
index 89d6539..afbeb20 100644
--- a/src/buildstream/_stream.py
+++ b/src/buildstream/_stream.py
@@ -112,9 +112,6 @@ class Stream():
         print("Kwargs: {}".format(list(kwargs.items())))
         assert not self._subprocess
 
-        global notification_count
-        notification_count = 0
-
         mp_context = mp.get_context(method='fork')
         process_name = "stream-{}".format(func.__name__)
         print("launchinglaunching subprocess:", process_name)
@@ -122,8 +119,10 @@ class Stream():
         self._subprocess.start()
 
         # TODO connect signal handlers
-        while self._subprocess.exitcode is not:
+        while self._subprocess.exitcode is None:
+            # check every given time interval on subprocess state
             self._subprocess.join(0.1)
+            # if no exit code, go back to checking the message queue
             self._loop()
         print("Stopping loop...")