You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rajith Attapattu (JIRA)" <ji...@apache.org> on 2011/04/12 18:57:06 UTC
[jira] [Created] (QPID-3205) NPE when setting the redelivery flag
is delivery props are missing (or if there are no headers at all)
NPE when setting the redelivery flag is delivery props are missing (or if there are no headers at all)
------------------------------------------------------------------------------------------------------
Key: QPID-3205
URL: https://issues.apache.org/jira/browse/QPID-3205
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: 0.10
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
Fix For: 0.11
In the 0-10 code path, when resuming a session we replay all the unacked messages in the replay buffer, after setting the redelivery flag.
However when doing so we need to check if the delivery properties are present.
The current implementation doesn't do so simply bcos the JMS client always sets delivery properties when sending messages.
However this results in a test failure (testResumeNonemptyReplayBuffer in Connection.java) and this code can be used in the future for QMF etc.. and they could potentially send messages without delivery props. So better to handle the null cases to avoid any NPE's.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3205) NPE when setting the redelivery flag
is delivery props are missing (or if there are no headers at all)
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu resolved QPID-3205.
------------------------------------
Resolution: Fixed
Fixed and verified using testResumeEmptyReplayBuffer in ConnectionTest.java
> NPE when setting the redelivery flag is delivery props are missing (or if there are no headers at all)
> ------------------------------------------------------------------------------------------------------
>
> Key: QPID-3205
> URL: https://issues.apache.org/jira/browse/QPID-3205
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.11
>
>
> In the 0-10 code path, when resuming a session we replay all the unacked messages in the replay buffer, after setting the redelivery flag.
> However when doing so we need to check if the delivery properties are present.
> The current implementation doesn't do so simply bcos the JMS client always sets delivery properties when sending messages.
> However this results in a test failure (testResumeNonemptyReplayBuffer in Connection.java) and this code can be used in the future for QMF etc.. and they could potentially send messages without delivery props. So better to handle the null cases to avoid any NPE's.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org