You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/16 15:21:32 UTC
[GitHub] larroy commented on a change in pull request #11302: [MXNET-553]
Restructure dockcross dockerfiles to fix caching
larroy commented on a change in pull request #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching
URL: https://github.com/apache/incubator-mxnet/pull/11302#discussion_r195772709
##########
File path: ci/docker/install/deb_ubuntu_ccache.sh
##########
@@ -43,7 +43,9 @@ git clone --recursive -b v3.4.2 https://github.com/ccache/ccache.git
cd ccache
./autogen.sh
-./configure
+# Manually specify x86 gcc versions so that this script remains compatible with dockcross (which uses an ARM based gcc
+# by default).
+CC=/usr/bin/gcc CXX=/usr/bin/g++ ./configure
Review comment:
Can't we set this environment variable in the docker file and then unset it? Since it's specific to dockcross.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services