You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/06/04 22:20:27 UTC
[kudu-CR] tablet: fix linker error
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16033
to review the following change.
Change subject: tablet: fix linker error
......................................................................
tablet: fix linker error
Following 97d775ae883181645dfcbbf1c4c18affc130ea78, building on Centos 6
in release mode nets me:
lib/../src/kudu/tablet/CMakeFiles/tablet_test_util.dir/tablet_replica-test-base.cc.o: In function `kudu::tablet::TabletReplicaTestBase::RestartReplica()':
/data/8/awong/Repositories/kudu/build/release/../../src/kudu/tablet/tablet_replica-test-base.cc:167: undefined reference to `kudu::tablet::BootstrapTablet(scoped_refptr<kudu::tablet::TabletMetadata>, kudu::consensus::RaftConfigPB, kudu:
:clock::Clock*, std::shared_ptr<kudu::MemTracker>, scoped_refptr<kudu::rpc::ResultTracker>, kudu::MetricRegistry*, kudu::FileCache*, scoped_refptr<kudu::tablet::TabletReplica>, scoped_refptr<kudu::log::LogAnchorRegistry>, std::shared_pt
r<kudu::tablet::Tablet>*, scoped_refptr<kudu::log::Log>*, kudu::consensus::ConsensusBootstrapInfo*)'
Seems like the tablet submodule wasn't being linked into
tablet-test-util. Also fixed some relevant spacing.
Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
---
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/tablet_replica-test-base.cc
2 files changed, 19 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/16033/1
--
To view, visit http://gerrit.cloudera.org:8080/16033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
Gerrit-Change-Number: 16033
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] tablet: fix linker error
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16033
to look at the new patch set (#2).
Change subject: tablet: fix linker error
......................................................................
tablet: fix linker error
Following 97d775ae883181645dfcbbf1c4c18affc130ea78, building on Centos 6
in release mode nets me:
lib/../src/kudu/tablet/CMakeFiles/tablet_test_util.dir/tablet_replica-test-base.cc.o: In function `kudu::tablet::TabletReplicaTestBase::RestartReplica()':
/data/8/awong/Repositories/kudu/build/release/../../src/kudu/tablet/tablet_replica-test-base.cc:167: undefined reference to `kudu::tablet::BootstrapTablet(scoped_refptr<kudu::tablet::TabletMetadata>, kudu::consensus::RaftConfigPB, kudu:
:clock::Clock*, std::shared_ptr<kudu::MemTracker>, scoped_refptr<kudu::rpc::ResultTracker>, kudu::MetricRegistry*, kudu::FileCache*, scoped_refptr<kudu::tablet::TabletReplica>, scoped_refptr<kudu::log::LogAnchorRegistry>, std::shared_pt
r<kudu::tablet::Tablet>*, scoped_refptr<kudu::log::Log>*, kudu::consensus::ConsensusBootstrapInfo*)'
Seems like the tablet submodule wasn't being linked into
tablet-test-util. Also fixed some relevant spacing.
Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
---
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/tablet_replica-test-base.cc
2 files changed, 20 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/16033/2
--
To view, visit http://gerrit.cloudera.org:8080/16033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
Gerrit-Change-Number: 16033
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: fix linker error
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16033 )
Change subject: tablet: fix linker error
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
Gerrit-Change-Number: 16033
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Jun 2020 22:28:56 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: fix linker error
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16033 )
Change subject: tablet: fix linker error
......................................................................
tablet: fix linker error
Following 97d775ae883181645dfcbbf1c4c18affc130ea78, building on Centos 6
in release mode nets me:
lib/../src/kudu/tablet/CMakeFiles/tablet_test_util.dir/tablet_replica-test-base.cc.o: In function `kudu::tablet::TabletReplicaTestBase::RestartReplica()':
/data/8/awong/Repositories/kudu/build/release/../../src/kudu/tablet/tablet_replica-test-base.cc:167: undefined reference to `kudu::tablet::BootstrapTablet(scoped_refptr<kudu::tablet::TabletMetadata>, kudu::consensus::RaftConfigPB, kudu:
:clock::Clock*, std::shared_ptr<kudu::MemTracker>, scoped_refptr<kudu::rpc::ResultTracker>, kudu::MetricRegistry*, kudu::FileCache*, scoped_refptr<kudu::tablet::TabletReplica>, scoped_refptr<kudu::log::LogAnchorRegistry>, std::shared_pt
r<kudu::tablet::Tablet>*, scoped_refptr<kudu::log::Log>*, kudu::consensus::ConsensusBootstrapInfo*)'
Seems like the tablet submodule wasn't being linked into
tablet-test-util. Also fixed some relevant spacing.
Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
Reviewed-on: http://gerrit.cloudera.org:8080/16033
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/tablet_replica-test-base.cc
2 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I364d83cff7f20868f818270daac4d3529ca84dfc
Gerrit-Change-Number: 16033
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)