You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/05/11 14:18:39 UTC

[GitHub] [ratis] guihecheng edited a comment on pull request #477: RATIS-1375. Handle bad storage dir due to disk failures.

guihecheng edited a comment on pull request #477:
URL: https://github.com/apache/ratis/pull/477#issuecomment-838450149


   @szetszwo oh, sorry for the style problem, will fix it.
   And for the ut case, I should handle the exception path properly. 
   Originally, it should get an `OverlappingFileLockException` followed/wrapped by an `IOException`, and they will not match 'AccessDeniedException' and will be thrown inside the loop.
   For now, the second `IOException` is caught and handled, and we throw a new `IOException` outside the loop.
   I tried to keep the test logic and throw the specific exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org