[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #706: Rename concurrency to default_partitions

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #706:
URL: https://github.com/apache/arrow-datafusion/pull/706#discussion_r667508175



##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -147,10 +147,10 @@ impl LogicalPlanBuilder {
     pub fn scan_parquet_with_name(
         path: impl Into<String>,
         projection: Option<Vec<usize>>,
-        max_concurrency: usize,
+        max_partitions: usize,
         table_name: impl Into<String>,
     ) -> Result<Self> {
-        let provider = Arc::new(ParquetTable::try_new(path, max_concurrency)?);
+        let provider = Arc::new(ParquetTable::try_new(path, max_partitions)?);

Review comment:
       One concern: when increasing the partitions, we also increase the number of maximum nr of threads while reading parquet. I think this should be decoupled.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org