[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38734: [SPARK-41212][CONNECT][PYTHON] Implement `DataFrame.isEmpty`

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38734:
URL: https://github.com/apache/spark/pull/38734#discussion_r1028721327


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -122,6 +122,20 @@ def withPlan(cls, plan: plan.LogicalPlan, session: "RemoteSparkSession") -> "Dat
         new_frame._plan = plan
         return new_frame
 
+    def isEmpty(self) -> bool:
+        """Returns ``True`` if this :class:`DataFrame` is empty.
+
+        .. versionadded:: 3.4.0
+
+        Returns
+        -------
+        bool
+            Whether it's empty DataFrame or not.
+        """
+        if "is_empty" not in self._cache:
+            self._cache["is_empty"] = len(self.take(1)) == 0
+        return bool(self._cache["is_empty"])

Review Comment:
   I am fine with that but we can even do the caching in the DataFrame instead of Spark Connect I guess (?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org