[GitHub] [hudi] yihua commented on a diff in pull request #6650: [minor] following HUDI-4828, fix the extraction for record keys conta…

[GitBox <gi...@apache.org>]

yihua commented on code in PR #6650:
URL: https://github.com/apache/hudi/pull/6650#discussion_r967684336


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java:
##########
@@ -74,7 +74,7 @@ public static String getPartitionPathFromGenericRecord(GenericRecord genericReco
   public static String[] extractRecordKeys(String recordKey) {
     String[] fieldKV = recordKey.split(",");
     return Arrays.stream(fieldKV).map(kv -> {
-      final String[] kvArray = kv.split(":");
+      final String[] kvArray = kv.split(":", 2);

Review Comment:
   I assume this is needed when the value contains a colon (:).  Could you add a unit test for that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org