[GitHub] [lucene] rmuir commented on a change in pull request #360: LUCENE-10155: Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase

[GitBox <gi...@apache.org>]

rmuir commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r724042253



##########
File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##########
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
     this.blockReuse = Objects.requireNonNull(blockReuse, "Block reuse must not be null.");
   }
 

Review comment:
       I had the same problem. I tend to lean towards the defaults should be fast, but the permissible values should be ones that work correctly.
   
   It is also not efficient to use MMapDirectory with 4-byte memory mappings: but it works correctly and we take advantage of this in testing.
   
   Funny history to this test in question: https://issues.apache.org/jira/browse/LUCENE-2627




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org