You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/30 09:45:43 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1974: Automate the process of creating jvm only extensions

jamesnetherton opened a new pull request #1974:
URL: https://github.com/apache/camel-quarkus/pull/1974


   This is a bit of an experiment which we can always remove if it ends up being not useful.
   
   It lets you create JVM only extensions for a list of camel components. To run you'd do:
   
   Actions -> Generate JVM Extensions -> Run Workflow
   
   Then enter a list of artifact ids to add. It'll run the cq-maven-plugin, make sure the tests pass & create a PR.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1974: Automate the process of creating jvm only extensions

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1974:
URL: https://github.com/apache/camel-quarkus/pull/1974#issuecomment-719459059


   Latest commit updates the input parameter description.
   
   I'll merge and try it out on `aws2-eventbridge`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1974: Automate the process of creating jvm only extensions

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1974:
URL: https://github.com/apache/camel-quarkus/pull/1974#discussion_r514979695



##########
File path: .github/workflows/generate-jvm-extension.yaml
##########
@@ -0,0 +1,82 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Generate JVM Extensions
+
+on:
+  workflow_dispatch:
+    inputs:
+      artifactIds:
+        description: 'Comma separated list of Camel component artifact ids'

Review comment:
       An example would be handy to see whether they should be with or without the `camel-` prefix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1974: Automate the process of creating jvm only extensions

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1974:
URL: https://github.com/apache/camel-quarkus/pull/1974#discussion_r514982035



##########
File path: .github/workflows/generate-jvm-extension.yaml
##########
@@ -0,0 +1,82 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Generate JVM Extensions
+
+on:
+  workflow_dispatch:
+    inputs:
+      artifactIds:
+        description: 'Comma separated list of Camel component artifact ids'

Review comment:
       It can be with or without, as the `camel-` prefix is stripped out. But I can tweak the description so that it's obvious.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton merged pull request #1974: Automate the process of creating jvm only extensions

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1974:
URL: https://github.com/apache/camel-quarkus/pull/1974


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1974: Automate the process of creating jvm only extensions

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1974:
URL: https://github.com/apache/camel-quarkus/pull/1974#discussion_r514982675



##########
File path: .github/workflows/generate-jvm-extension.yaml
##########
@@ -0,0 +1,82 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Generate JVM Extensions
+
+on:
+  workflow_dispatch:
+    inputs:
+      artifactIds:
+        description: 'Comma separated list of Camel component artifact ids'

Review comment:
       Nifty!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org