You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/12/01 17:14:12 UTC
[PR] Add basic support of virtual threads [camel]
essobedo opened a new pull request, #12292:
URL: https://github.com/apache/camel/pull/12292
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add basic support of virtual threads [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #12292:
URL: https://github.com/apache/camel/pull/12292#discussion_r1414132186
##########
core/camel-support/pom.xml:
##########
@@ -85,4 +85,53 @@
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>java-21-sources</id>
Review Comment:
No unfortunately maven doesn't support it out of the box. They only propose different approaches to do so https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html and I more or less picked one of them.
To remove the profile, I would need to enforce Java 21 but I wanted to avoid being too intrusive but if it is not an issue for you all, I can enforce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add basic support of virtual threads [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12292:
URL: https://github.com/apache/camel/pull/12292#issuecomment-1836484761
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add basic support of virtual threads [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12292:
URL: https://github.com/apache/camel/pull/12292#issuecomment-1837160169
It would be good to have a bit of doc on this, such as at
https://camel.apache.org/manual/threading-model.html
And we can then try this for 4.3 as a non LTS release to see if we can have it work and build for Gregor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add basic support of virtual threads [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12292:
URL: https://github.com/apache/camel/pull/12292#discussion_r1414325145
##########
core/camel-support/pom.xml:
##########
@@ -85,4 +85,53 @@
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>java-21-sources</id>
Review Comment:
Understood. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add basic support of virtual threads [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12292:
URL: https://github.com/apache/camel/pull/12292#discussion_r1413826116
##########
core/camel-support/pom.xml:
##########
@@ -85,4 +85,53 @@
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>java-21-sources</id>
Review Comment:
Just out of curiosity: can't we support multi-release jars without Maven profiles? I never really worked with this, so I apologize if it's a dumb question, but my always thought Maven supported this "out of the box" in many cases and with a few specialized plugins in others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add basic support of virtual threads [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #12292:
URL: https://github.com/apache/camel/pull/12292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org