You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/06 13:19:49 UTC
[GitHub] [airflow] sdebruyn opened a new pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
sdebruyn opened a new pull request #19442:
URL: https://github.com/apache/airflow/pull/19442
My connection to Azure Data Factory was not working with the current version and after investigation I found out that it was looking for different keys in my connection than the ones in the documentation.
The key in the docs: `factoryName`
The key that actually worked: `extra__azure_data_factory__factory_name `
I changed both the hook and the documentation and used `_` for consistency in the keys.
@ reviewer: I am unsure about my changes in `get_connection_form_widgets` Feedback is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962609820
> @potiuk @mik-laj Yes, but do you think anyone is using this? I had to dig deep to understand what it was looking for. It's also still quite new.
Let me reverse your question. Are you absolutely sure no-one is using it @sdebruyn ?
We have no idea if the features are used but we are very strict about backwards compatibility and unless there is a good reason we are not breaking it - netiher in Airflow, nor providers. Any backwards-incompatible change like that must be justified and bring some real beneefits in order to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962609820
> @potiuk @mik-laj Yes, but do you think anyone is using this? I had to dig deep to understand what it was looking for. It's also still quite new.
Let me reverse it. Are you absolutely sure no-one is using it @sdebruyn ?
We have no idea if the features are used but we are very strict about backwards compatibility and unless there is a good reason we are not breaking it - netiher in Airflow, nor providers. Any backwards-incompatible change like that must be justified and bring some real beneefits in order to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962609820
> @potiuk @mik-laj Yes, but do you think anyone is using this? I had to dig deep to understand what it was looking for. It's also still quite new.
Let me reverse it. Are you absolutely sure no-one is using it @sdebruyn ?
We have no idea if the features are used but we are very strict about backwards compatibility and unless there is a good reason we are not breaking it - netiher in Airflow, nor providers. Any backwrds-incompatible change like that must be justified and bring some real beneefits in order to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sdebruyn commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
sdebruyn commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962609206
@potiuk @mik-laj Yes, but do you think anyone is using this? I had to dig deep to understand what it was looking for. It's also still quite new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sdebruyn commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
sdebruyn commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962466365
Failing CI build seems unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962681779
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sdebruyn commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
sdebruyn commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962942241
@potiuk should be fixed, they all pass locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sdebruyn commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
sdebruyn commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962681396
@potiuk @mik-laj agreed, reverted the code changes and corrected the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#discussion_r744243667
##########
File path: airflow/providers/microsoft/azure/hooks/data_factory.py
##########
@@ -141,8 +141,8 @@ def get_conn(self) -> DataFactoryManagementClient:
return self._conn
conn = self.get_connection(self.conn_id)
- tenant = conn.extra_dejson.get('extra__azure_data_factory__tenantId')
- subscription_id = conn.extra_dejson.get('extra__azure_data_factory__subscriptionId')
+ tenant = conn.extra_dejson.get('tenant_id')
Review comment:
It looks like a breaking change. Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19442:
URL: https://github.com/apache/airflow/pull/19442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19442: Fix mismatch between docs and Azure Data Factory Hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19442:
URL: https://github.com/apache/airflow/pull/19442#issuecomment-962689154
Statuc checks failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org