You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/09 07:48:47 UTC
[GitHub] [incubator-doris] whutpencil opened a new pull request, #9464: [Enhancement] add config to optimize load balance of label class HIGH
whutpencil opened a new pull request, #9464:
URL: https://github.com/apache/incubator-doris/pull/9464
# Proposed changes
Issue Number: #9463
## Problem Summary:
Please refer to issue for problem description.
The solution is to add configuration items to make the method of determining HIGH label more reasonable.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] dataalive commented on a diff in pull request #9464: [Enhancement] add config to optimize load balance of label class HIGH
Posted by GitBox <gi...@apache.org>.
dataalive commented on code in PR #9464:
URL: https://github.com/apache/incubator-doris/pull/9464#discussion_r870464307
##########
docs/en/admin-manual/config/fe-config.md:
##########
@@ -704,7 +704,17 @@ IsMutable:true
MasterOnly:true
-the threshold of cluster balance score, if a backend's load score is 10% lower than average score, this backend will be marked as LOW load, if load score is 10% higher than average score, HIGH load will be marked
+the threshold of cluster balance score, if a backend's load score is 10% lower than average score, this backend will be marked as LOW load, if load score is 10% higher than average score, and its capacity usedPercent is greater than the config `high_load_capacity_used_percent_threshold`, default 0.4, HIGH load will be marked
Review Comment:
default value 0.4 should be 0.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] whutpencil commented on pull request #9464: [Enhancement] add config to optimize load balance of label class HIGH
Posted by GitBox <gi...@apache.org>.
whutpencil commented on PR #9464:
URL: https://github.com/apache/incubator-doris/pull/9464#issuecomment-1120775361
@morningman PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] whutpencil commented on pull request #9464: [Enhancement] add config to optimize load balance of label class HIGH
Posted by GitBox <gi...@apache.org>.
whutpencil commented on PR #9464:
URL: https://github.com/apache/incubator-doris/pull/9464#issuecomment-1138305879
@morningman please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #9464: [Enhancement] add config to optimize load balance of label class HIGH
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #9464: [Enhancement] add config to optimize load balance of label class HIGH
URL: https://github.com/apache/doris/pull/9464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #9464: [Enhancement] add config to optimize load balance of label class HIGH
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9464:
URL: https://github.com/apache/doris/pull/9464#issuecomment-1324388384
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org