You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/08 06:38:37 UTC

[GitHub] [iotdb] jixuan1989 opened a new pull request #3374: [IOTDB-1429]fix failsafe-plugin not report failures issue

jixuan1989 opened a new pull request #3374:
URL: https://github.com/apache/iotdb/pull/3374


   When running commands like `mvn integration-test`, we may find some tests fail but the maven reports SUCCESS, see:
   
   https://github.com/apache/iotdb/runs/2655279613
   
    
   
   [main] Docker Compose has finished running 
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.252 s - in org.apache.iotdb.db.sql.node1.OneNodeClusterIT
   [INFO] 
   [INFO] Results:
   [INFO] 
   Error:  Errors: 
   Error:    FiveNodeCluster1IT>Cases.vectorCountTest:205 » StatementExecution 313: Request...
   [INFO] 
   Error:  Tests run: 21, Failures: 0, Errors: 1, Skipped: 0
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  07:21 min
   [INFO] Finished at: 2021-05-24T10:55:21Z
   [INFO] ------------------------------------------------------------------------
     
   
   It is caused by incorrect maven-failsafe-plugin usage.
   
   Details: we need to add `verify` as a goal in the plugin.
   
   see: http://maven.40175.n5.nabble.com/Failing-a-build-with-maven-failsafe-plugin-td3199308.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #3374: [IOTDB-1429]fix failsafe-plugin not report failures issue

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #3374:
URL: https://github.com/apache/iotdb/pull/3374#issuecomment-856528257


   
   [![Coverage Status](https://coveralls.io/builds/40389993/badge)](https://coveralls.io/builds/40389993)
   
   Coverage increased (+0.03%) to 67.904% when pulling **efe17cf2de26ce4aed15e7580cd7b4164ae8f521 on jira1429** into **66918f3f8e2cbae03fe2bfd4ecc56c7dadd79cbf on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #3374: [IOTDB-1429]fix failsafe-plugin not report failures issue

Posted by GitBox <gi...@apache.org>.

HTHou merged pull request #3374:
URL: https://github.com/apache/iotdb/pull/3374


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #3374: [IOTDB-1429]fix failsafe-plugin not report failures issue

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on pull request #3374:
URL: https://github.com/apache/iotdb/pull/3374#issuecomment-858252448


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3374&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='86.9%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3374&metric=new_coverage&view=list) [86.9% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3374&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3374&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3374&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org