You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by DanielYWoo <gi...@git.apache.org> on 2017/04/06 04:09:33 UTC
[GitHub] thrift pull request #1240: return full error message when exception happens
GitHub user DanielYWoo opened a pull request:
https://github.com/apache/thrift/pull/1240
return full error message when exception happens
If you throw an exception with error message, the error message will be IGNORED and replaced with a generic message like "Internal processing error getUserInfo". The pull request will append the ACTUAL error message to that message. e,g. "Internal processing error getUserInfo, error message: Cannot connect to database"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DanielYWoo/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1240
----
commit 61138b8c3392fdb6cd546cacfc2c6b87fc77ca04
Author: Daniel Wu <da...@gmail.com>
Date: 2017-04-06T04:07:10Z
return full error message when exception happens
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1240: return full error message when exception happens
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1240
This is related to THRIFT-3607.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1240: return full error message when exception happens
Posted by DanielYWoo <gi...@git.apache.org>.
Github user DanielYWoo commented on the issue:
https://github.com/apache/thrift/pull/1240
Yes, we probably keep a patch list for this. Thanks Jeking3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1240: return full error message when exception happens
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1240
In a project I work on that uses thrift, the company maintains a set of patches they pull (mostly from master, where defects have been fixed on top of 0.10.0) that they need to ship something that works for them. If you need to change the core exception handling behavior for your project, you can always do so in your own release engineering workflow regardless of whether a patch gets accepted and merged upstream. That said, you are always welcome to submit a patch, certainly. There may be other folks who use thrift who would want the same option, perhaps for standing up a new service for internal QA and getting more rapid identification of issues during testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1240: return full error message when exception happens
Posted by DanielYWoo <gi...@git.apache.org>.
Github user DanielYWoo commented on the issue:
https://github.com/apache/thrift/pull/1240
Thanks for explanation. In our case, we have a web server layer on top of many layers of backends which communicate in thrift, e,g.
> web server -> backend A -> backend B -> backend C.
It will be very difficult for trouble shooting on the web server or backend A. Since we will never ever show exception message from the web server to the browser or client app, so there is no way to trigger an exception and see the details of the backend servers. I believe the developers of the web servers or API gateways have the responsibility to keep the details no leaking to the outside of the world. Enforcing security at the thrift layer is fine but I just hope there is an alternative or option to enable this.
Would you accept a global configurable variable for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1240: return full error message when exception happens
Posted by DanielYWoo <gi...@git.apache.org>.
Github user DanielYWoo closed the pull request at:
https://github.com/apache/thrift/pull/1240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---