You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/04/12 11:35:52 UTC
svn commit: r933165 -
/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Author: markt
Date: Mon Apr 12 09:35:52 2010
New Revision: 933165
URL: http://svn.apache.org/viewvc?rev=933165&view=rev
Log:
Make public constant final
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java Mon Apr 12 09:35:52 2010
@@ -38,7 +38,7 @@ import java.sql.Timestamp;
public class ChannelData implements ChannelMessage {
public static final ChannelData[] EMPTY_DATA_ARRAY = new ChannelData[0];
- public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
+ public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
/**
* The options this message was sent with
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by sebb <se...@gmail.com>.
On 13/04/2010, Filip Hanik - Dev Lists <de...@hanik.com> wrote:
> This makes zero sense and I would do a -1 on this commit and the bug in
> general.
A public static mutable field is nearly always not thread-safe, and is
often actually thread hostile.
> What effectively has happened here is that there has been a public API
> change without any justification.
See above for reasoning.
> Since this is a mutable field, you've now made it non mutable. and in there
> lies the change.
Yes, it is a change.
Tomcat 7 has not yet been released, so it seems to me that this is the
best time to fix an errors such as this.
It will be very difficult to fix any such errors later (as you point out).
> Filip
>
>
> On 04/12/2010 12:59 PM, sebb wrote:
>
> > On 12/04/2010, Mark Thomas<ma...@apache.org> wrote:
> >
> >
> > > On 12/04/2010 11:53, Tim Funk wrote:
> > > > This seems like an odd thing to make a constant. (Is something else
> > > > setting this or was there an intention for this to be set?
> Especially
> > > > since it is used only once in this file)
> > >
> > >
> > > It isn't entirely clear. I suspect it was going to be made configurable
> > > at start-up at some point. The naming convention implies constant. If
> it
> > > is ever made configurable, the final can be removed if required.
> > >
> > >
> > This was done to fix:
> >
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
> >
> > If it is ever made mutable, please consider making it a private
> > instance variable instead of a thread-hostile mutable static.
> >
> >
> >
> > > Mark
> > >
> > >
> > > >
> > > > -Tim
> > > >
> > > > On 4/12/2010 5:35 AM, markt@apache.org wrote:
> > > >> Author: markt
> > > >> Date: Mon Apr 12 09:35:52 2010
> > > >> New Revision: 933165
> > > >>
> > > >> URL:
> http://svn.apache.org/viewvc?rev=933165&view=rev
> > > >> Log:
> > > >> Make public constant final
> > > >>
> > > >> Modified:
> > > >>
> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> > > >>
> > > >> Modified:
> > > >>
> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> > > >> URL:
> > > >>
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
> > > >>
> > > >>
> ==============================================================================
> > > >>
> > > >> ---
> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> > > >> (original)
> > > >> +++
> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> > > >> Mon Apr 12 09:35:52 2010
> > > >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
> > > >> public class ChannelData implements ChannelMessage {
> > > >> public static final ChannelData[] EMPTY_DATA_ARRAY = new
> > > >> ChannelData[0];
> > > >>
> > > >> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
> > > >> + public static final boolean USE_SECURE_RANDOM_FOR_UUID =
> false;
> > > >>
> > > >> /**
> > > >> * The options this message was sent with
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
> dev-unsubscribe@tomcat.apache.org
> > > > For additional commands, e-mail: dev-help@tomcat.apache.org
> > > >
> > >
> > >
> > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> dev-unsubscribe@tomcat.apache.org
> > > For additional commands, e-mail: dev-help@tomcat.apache.org
> > >
> > >
> > >
> > >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Need help in setting up virtual url for tomcat 5
Posted by Xie Xiaodong <xx...@gmail.com>.
users@tomcat.apache.org
On Wed, Apr 14, 2010 at 12:42 PM, Vivek Kanchan
<vi...@oracle.com>wrote:
> please give me the id..
> thanks
>
>
> -----Original Message-----
> From: Mark Thomas [mailto:markt@apache.org]
> Sent: Wednesday, April 14, 2010 4:02 PM
> To: Tomcat Developers List
> Subject: Re: Need help in setting up virtual url for tomcat 5
>
>
> On 14/04/2010 11:29, Vivek Kanchan wrote:
> > HI,
> >
> > I have setup tomcat 5 for a customer, now i need to use virtual url and
> por=
> > t
> > t other than 8080 , please let me know how to do it , what files to
> change =
> > for these.
>
> Please use the Tomcat users mailing list.
>
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
--
Sincerely yours and Best Regards,
Xie Xiaodong
RE: Need help in setting up virtual url for tomcat 5
Posted by Vivek Kanchan <vi...@oracle.com>.
please give me the id..
thanks
-----Original Message-----
From: Mark Thomas [mailto:markt@apache.org]
Sent: Wednesday, April 14, 2010 4:02 PM
To: Tomcat Developers List
Subject: Re: Need help in setting up virtual url for tomcat 5
On 14/04/2010 11:29, Vivek Kanchan wrote:
> HI,
>
> I have setup tomcat 5 for a customer, now i need to use virtual url and por=
> t
> t other than 8080 , please let me know how to do it , what files to change =
> for these.
Please use the Tomcat users mailing list.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Need help in setting up virtual url for tomcat 5
Posted by Mark Thomas <ma...@apache.org>.
On 14/04/2010 11:29, Vivek Kanchan wrote:
> HI,
>
> I have setup tomcat 5 for a customer, now i need to use virtual url and por=
> t
> t other than 8080 , please let me know how to do it , what files to change =
> for these.
Please use the Tomcat users mailing list.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Need help in setting up virtual url for tomcat 5
Posted by Vivek Kanchan <vi...@oracle.com>.
HI,
I have setup tomcat 5 for a customer, now i need to use virtual url and por=
t
t other than 8080 , please let me know how to do it , what files to change =
for these.
Thanks,
Vivyek kanchan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by sebb <se...@gmail.com>.
On 14/04/2010, Mark Thomas <ma...@apache.org> wrote:
> On 13/04/2010 17:48, Filip Hanik - Dev Lists wrote:
> > This makes zero sense and I would do a -1 on this commit and the bug in
> > general.
> > What effectively has happened here is that there has been a public API
> > change without any justification.
> >
> > Since this is a mutable field, you've now made it non mutable. and in
> > there lies the change.
>
>
> Fair point. I'll remove the final but make it volatile to avoid any
> threading issues.
Sorry to go on about this, but AFAICT volatile does not really help here.
The boolean is not used for communication between threads, it is used
as a configuration option.
If two different threads want two different values then there is a
conflict. If there is never any need to change the value, then there
is no need for volatile.
Is the current API really immutable at this stage?
> Mark
>
>
> >
> > Filip
> >
> > On 04/12/2010 12:59 PM, sebb wrote:
> >> On 12/04/2010, Mark Thomas<ma...@apache.org> wrote:
> >>
> >>> On 12/04/2010 11:53, Tim Funk wrote:
> >>> > This seems like an odd thing to make a constant. (Is something else
> >>> > setting this or was there an intention for this to be set?
> >>> Especially
> >>> > since it is used only once in this file)
> >>>
> >>>
> >>> It isn't entirely clear. I suspect it was going to be made configurable
> >>> at start-up at some point. The naming convention implies constant.
> >>> If it
> >>> is ever made configurable, the final can be removed if required.
> >>>
> >> This was done to fix:
> >>
> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
> >>
> >> If it is ever made mutable, please consider making it a private
> >> instance variable instead of a thread-hostile mutable static.
> >>
> >>
> >>> Mark
> >>>
> >>>
> >>> >
> >>> > -Tim
> >>> >
> >>> > On 4/12/2010 5:35 AM, markt@apache.org wrote:
> >>> >> Author: markt
> >>> >> Date: Mon Apr 12 09:35:52 2010
> >>> >> New Revision: 933165
> >>> >>
> >>> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
> >>> >> Log:
> >>> >> Make public constant final
> >>> >>
> >>> >> Modified:
> >>> >>
> >>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >>
> >>> >> Modified:
> >>> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >> URL:
> >>> >>
> >>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
> >>>
> >>> >>
> >>> >>
> >>> ==============================================================================
> >>>
> >>> >>
> >>> >> ---
> >>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >> (original)
> >>> >> +++
> >>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >> Mon Apr 12 09:35:52 2010
> >>> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
> >>> >> public class ChannelData implements ChannelMessage {
> >>> >> public static final ChannelData[] EMPTY_DATA_ARRAY = new
> >>> >> ChannelData[0];
> >>> >>
> >>> >> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
> >>> >> + public static final boolean USE_SECURE_RANDOM_FOR_UUID =
> >>> false;
> >>> >>
> >>> >> /**
> >>> >> * The options this message was sent with
> >>> >
> >>> >
> >>> ---------------------------------------------------------------------
> >>> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >>> >
> >>>
> >>>
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>>
> >>>
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >>
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by Mark Thomas <ma...@apache.org>.
On 13/04/2010 17:48, Filip Hanik - Dev Lists wrote:
> This makes zero sense and I would do a -1 on this commit and the bug in
> general.
> What effectively has happened here is that there has been a public API
> change without any justification.
>
> Since this is a mutable field, you've now made it non mutable. and in
> there lies the change.
Fair point. I'll remove the final but make it volatile to avoid any
threading issues.
Mark
>
> Filip
>
> On 04/12/2010 12:59 PM, sebb wrote:
>> On 12/04/2010, Mark Thomas<ma...@apache.org> wrote:
>>
>>> On 12/04/2010 11:53, Tim Funk wrote:
>>> > This seems like an odd thing to make a constant. (Is something else
>>> > setting this or was there an intention for this to be set?
>>> Especially
>>> > since it is used only once in this file)
>>>
>>>
>>> It isn't entirely clear. I suspect it was going to be made configurable
>>> at start-up at some point. The naming convention implies constant.
>>> If it
>>> is ever made configurable, the final can be removed if required.
>>>
>> This was done to fix:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
>>
>> If it is ever made mutable, please consider making it a private
>> instance variable instead of a thread-hostile mutable static.
>>
>>
>>> Mark
>>>
>>>
>>> >
>>> > -Tim
>>> >
>>> > On 4/12/2010 5:35 AM, markt@apache.org wrote:
>>> >> Author: markt
>>> >> Date: Mon Apr 12 09:35:52 2010
>>> >> New Revision: 933165
>>> >>
>>> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
>>> >> Log:
>>> >> Make public constant final
>>> >>
>>> >> Modified:
>>> >>
>>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >>
>>> >> Modified:
>>> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >> URL:
>>> >>
>>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
>>>
>>> >>
>>> >>
>>> ==============================================================================
>>>
>>> >>
>>> >> ---
>>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >> (original)
>>> >> +++
>>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >> Mon Apr 12 09:35:52 2010
>>> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
>>> >> public class ChannelData implements ChannelMessage {
>>> >> public static final ChannelData[] EMPTY_DATA_ARRAY = new
>>> >> ChannelData[0];
>>> >>
>>> >> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
>>> >> + public static final boolean USE_SECURE_RANDOM_FOR_UUID =
>>> false;
>>> >>
>>> >> /**
>>> >> * The options this message was sent with
>>> >
>>> >
>>> ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> > For additional commands, e-mail: dev-help@tomcat.apache.org
>>> >
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
On 04/14/2010 07:07 AM, Konstantin Kolinko wrote:
> 2010/4/13 Filip Hanik - Dev Lists<de...@hanik.com>:
>
>> This makes zero sense and I would do a -1 on this commit and the bug in
>> general.
>> What effectively has happened here is that there has been a public API
>> change without any justification.
>>
>> Since this is a mutable field, you've now made it non mutable. and in there
>> lies the change.
>>
>>
> I am +1 on the change.
>
doesn't change a veto
> If we need it configurable, let's define a system property to
> initialize its value at startup,
>
I agree, however that was not done in the original commit.
> or better to define an instance field somewhere.
>
again, I agree. If you're gonna change the API, do it right. Let's not
make variables "final" cause it's someone preference
> It makes no sense for me to flip between "secure random" and "insecure
> random" at runtime.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/4/13 Filip Hanik - Dev Lists <de...@hanik.com>:
> This makes zero sense and I would do a -1 on this commit and the bug in
> general.
> What effectively has happened here is that there has been a public API
> change without any justification.
>
> Since this is a mutable field, you've now made it non mutable. and in there
> lies the change.
>
I am +1 on the change.
If we need it configurable, let's define a system property to
initialize its value at startup,
or better to define an instance field somewhere.
It makes no sense for me to flip between "secure random" and "insecure
random" at runtime.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
This makes zero sense and I would do a -1 on this commit and the bug in
general.
What effectively has happened here is that there has been a public API
change without any justification.
Since this is a mutable field, you've now made it non mutable. and in
there lies the change.
Filip
On 04/12/2010 12:59 PM, sebb wrote:
> On 12/04/2010, Mark Thomas<ma...@apache.org> wrote:
>
>> On 12/04/2010 11:53, Tim Funk wrote:
>> > This seems like an odd thing to make a constant. (Is something else
>> > setting this or was there an intention for this to be set? Especially
>> > since it is used only once in this file)
>>
>>
>> It isn't entirely clear. I suspect it was going to be made configurable
>> at start-up at some point. The naming convention implies constant. If it
>> is ever made configurable, the final can be removed if required.
>>
> This was done to fix:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
>
> If it is ever made mutable, please consider making it a private
> instance variable instead of a thread-hostile mutable static.
>
>
>> Mark
>>
>>
>> >
>> > -Tim
>> >
>> > On 4/12/2010 5:35 AM, markt@apache.org wrote:
>> >> Author: markt
>> >> Date: Mon Apr 12 09:35:52 2010
>> >> New Revision: 933165
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
>> >> Log:
>> >> Make public constant final
>> >>
>> >> Modified:
>> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> >>
>> >> Modified:
>> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> >> URL:
>> >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
>> >>
>> >> ==============================================================================
>> >>
>> >> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> >> (original)
>> >> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> >> Mon Apr 12 09:35:52 2010
>> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
>> >> public class ChannelData implements ChannelMessage {
>> >> public static final ChannelData[] EMPTY_DATA_ARRAY = new
>> >> ChannelData[0];
>> >>
>> >> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
>> >> + public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
>> >>
>> >> /**
>> >> * The options this message was sent with
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> > For additional commands, e-mail: dev-help@tomcat.apache.org
>> >
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by sebb <se...@gmail.com>.
On 12/04/2010, Mark Thomas <ma...@apache.org> wrote:
> On 12/04/2010 11:53, Tim Funk wrote:
> > This seems like an odd thing to make a constant. (Is something else
> > setting this or was there an intention for this to be set? Especially
> > since it is used only once in this file)
>
>
> It isn't entirely clear. I suspect it was going to be made configurable
> at start-up at some point. The naming convention implies constant. If it
> is ever made configurable, the final can be removed if required.
This was done to fix:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
If it is ever made mutable, please consider making it a private
instance variable instead of a thread-hostile mutable static.
> Mark
>
>
> >
> > -Tim
> >
> > On 4/12/2010 5:35 AM, markt@apache.org wrote:
> >> Author: markt
> >> Date: Mon Apr 12 09:35:52 2010
> >> New Revision: 933165
> >>
> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
> >> Log:
> >> Make public constant final
> >>
> >> Modified:
> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>
> >> Modified:
> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >> URL:
> >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
> >>
> >> ==============================================================================
> >>
> >> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >> (original)
> >> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >> Mon Apr 12 09:35:52 2010
> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
> >> public class ChannelData implements ChannelMessage {
> >> public static final ChannelData[] EMPTY_DATA_ARRAY = new
> >> ChannelData[0];
> >>
> >> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
> >> + public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
> >>
> >> /**
> >> * The options this message was sent with
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by Mark Thomas <ma...@apache.org>.
On 12/04/2010 11:53, Tim Funk wrote:
> This seems like an odd thing to make a constant. (Is something else
> setting this or was there an intention for this to be set? Especially
> since it is used only once in this file)
It isn't entirely clear. I suspect it was going to be made configurable
at start-up at some point. The naming convention implies constant. If it
is ever made configurable, the final can be removed if required.
Mark
>
> -Tim
>
> On 4/12/2010 5:35 AM, markt@apache.org wrote:
>> Author: markt
>> Date: Mon Apr 12 09:35:52 2010
>> New Revision: 933165
>>
>> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
>> Log:
>> Make public constant final
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
>>
>> ==============================================================================
>>
>> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> (original)
>> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> Mon Apr 12 09:35:52 2010
>> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
>> public class ChannelData implements ChannelMessage {
>> public static final ChannelData[] EMPTY_DATA_ARRAY = new
>> ChannelData[0];
>>
>> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
>> + public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
>>
>> /**
>> * The options this message was sent with
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Posted by Tim Funk <fu...@apache.org>.
This seems like an odd thing to make a constant. (Is something else
setting this or was there an intention for this to be set? Especially
since it is used only once in this file)
-Tim
On 4/12/2010 5:35 AM, markt@apache.org wrote:
> Author: markt
> Date: Mon Apr 12 09:35:52 2010
> New Revision: 933165
>
> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
> Log:
> Make public constant final
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java Mon Apr 12 09:35:52 2010
> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
> public class ChannelData implements ChannelMessage {
> public static final ChannelData[] EMPTY_DATA_ARRAY = new ChannelData[0];
>
> - public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
> + public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
>
> /**
> * The options this message was sent with
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org