You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/26 17:15:19 UTC

[GitHub] [calcite-avatica] zabetak commented on a change in pull request #98: [CALCITE-3078] Duplicate code lastDay in calcite-avatica and calcite

zabetak commented on a change in pull request #98:
URL: https://github.com/apache/calcite-avatica/pull/98#discussion_r583791664



##########
File path: core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
##########
@@ -993,7 +993,7 @@ public static int addMonths(int date, int m) {
     return DateTimeUtils.ymdToUnixDate(y0, m0, d0);
   }
 
-  private static int lastDay(int y, int m) {
+  public static int lastDay(int y, int m) {

Review comment:
       Making the method public requires some javadoc. Can you please add a short description? 
   Although not strictly necessary adding tests will be a plus.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org