You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 12:17:44 UTC
[GitHub] [incubator-superset] michael-s-molina opened a new pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
michael-s-molina opened a new pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213
### SUMMARY
Remove tests errors and warnings to improve results readability.
#12212
@rusackas @junlincc @villebro
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.28% -2.93%
==========================================
Files 996 485 -511
Lines 49174 29815 -19359
Branches 4993 0 -4993
==========================================
- Hits 32554 18867 -13687
+ Misses 16476 10948 -5528
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.28% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [526 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754309115
@ktmud I updated the PR description with the fixed errors and warnings. I'll do the same with the other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-753897437
> thanks for the PRs @michael-s-molina! is there a test plan for them?
We just need to run the tests and verify that the errors and warnings are decreasing. Most of the changes are in spec files and the ones that change a component are covered by a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.58%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 62.61% -3.59%
==========================================
Files 996 996
Lines 49174 49173 -1
Branches 4993 4996 +3
==========================================
- Hits 32554 30791 -1763
- Misses 16476 18182 +1706
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `63.62% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `64.28% <0.00%> (-29.70%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <ø> (-23.62%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `56.29% <63.33%> (-9.36%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `56.32% <75.00%> (-0.09%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 64.04% -2.16%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19106 -13448
+ Misses 16476 10724 -5752
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.04% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | | |
| [...uperset-frontend/src/components/FacePile/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvdXRpbHMudHN4) | | |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.42%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 62.77% -3.43%
==========================================
Files 996 996
Lines 49174 49173 -1
Branches 4993 4996 +3
==========================================
- Hits 32554 30868 -1686
- Misses 16476 18105 +1629
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `63.87% <ø> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `64.28% <0.00%> (-29.70%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <ø> (-23.62%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `56.29% <63.33%> (-9.36%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `56.32% <75.00%> (-0.09%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [160 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 64.19% -2.01%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19149 -13405
+ Misses 16476 10681 -5795
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.19% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | | |
| [...erset-frontend/src/common/components/Tabs/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMvVGFicy50c3g=) | | |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | | |
| [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...uperset-frontend/src/components/AsyncAceEditor.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IudHN4) | | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | | |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | | |
| ... and [497 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754764221
@ktmud Accepted suggested changes. I did a force push to preserve commit history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **increase** coverage by `0.80%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
+ Coverage 66.20% 67.00% +0.80%
==========================================
Files 996 996
Lines 49174 49187 +13
Branches 4993 4996 +3
==========================================
+ Hits 32554 32959 +405
+ Misses 16476 16101 -375
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <15.90%> (+6.73%)` | :arrow_up: |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `64.22% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `92.85% <0.00%> (-1.12%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `87.50% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.22% <63.33%> (-3.43%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `72.15% <75.00%> (+15.74%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [69 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **increase** coverage by `0.90%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
+ Coverage 66.20% 67.10% +0.90%
==========================================
Files 996 996
Lines 49174 49187 +13
Branches 4993 4996 +3
==========================================
+ Hits 32554 33007 +453
+ Misses 16476 16057 -419
+ Partials 144 123 -21
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.28% <15.90%> (+7.18%)` | :arrow_up: |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `64.22% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `92.85% <0.00%> (-1.12%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `87.50% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.22% <63.33%> (-3.43%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `72.15% <75.00%> (+15.74%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [64 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 64.19% -2.01%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19149 -13405
+ Misses 16476 10681 -5795
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.19% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | | |
| [superset-frontend/src/common/components/Switch.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1N3aXRjaC50c3g=) | | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [...end/src/dashboard/util/findFirstParentContainer.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRGaXJzdFBhcmVudENvbnRhaW5lci5qcw==) | | |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | | |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
| [...-frontend/src/SqlLab/reducers/localStorageUsage.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9sb2NhbFN0b3JhZ2VVc2FnZS5qcw==) | | |
| ... and [497 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754309115
@ktmud I updated the PR description to include fixed errors and warnings. I'll do the same with the other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754309115
@ktmud I updated the PR description with fixed errors and warnings. I'll do the same with the other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754734369
Thanks so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.99% -2.21%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19091 -13463
+ Misses 16476 10739 -5737
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.99% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.58% -2.62%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 18967 -13587
+ Misses 16476 10863 -5613
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <ø> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#discussion_r552040881
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -138,41 +138,44 @@ const SubMenu: React.FunctionComponent<SubMenuProps> = props => {
props.tabs.map(tab => {
if ((props.usesRouter || hasHistory) && !!tab.usesRouter) {
return (
- <li
- className={tab.name === props.activeChild ? 'active' : ''}
- key={`${tab.label}`}
- >
- <div>
- <Link to={tab.url || ''}>{tab.label}</Link>
- </div>
- </li>
+ <React.Fragment key={`${tab.label}`}>
Review comment:
```suggestion
<React.Fragment key={tab.label}>
```
Does this work?
I assume this is also for fixing the `activeHref` warning from react-bootstrap? We should probably migrate the menu to AntD, but I guess this works, too.
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -296,9 +296,16 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
const id = database.id || 0;
setTabKey(DEFAULT_TAB_KEY);
- fetchResource(id).then(() => {
- setDB(dbFetched);
- });
+ fetchResource(id)
+ .then(() => {
+ setDB(dbFetched);
+ })
+ .catch(e =>
+ addDangerToast(
+ t('Sorry there was an error fetching database information: ') +
+ e.message,
Review comment:
```ts
t('Sorry there was an error fetching database information: %s', e.message)
```
Let's use interpolation for translations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 64.19% -2.01%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19149 -13405
+ Misses 16476 10681 -5795
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.19% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Pagination.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi50c3g=) | | |
| [...ntend/src/components/dataViewCommon/Pagination.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vUGFnaW5hdGlvbi50c3g=) | | |
| [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | | |
| [...d/src/dashboard/util/getLeafComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExlYWZDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | | |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | | |
| ... and [497 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.59% -2.61%
==========================================
Files 996 485 -511
Lines 49174 29815 -19359
Branches 4993 0 -4993
==========================================
- Hits 32554 18960 -13594
+ Misses 16476 10855 -5621
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.59% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [512 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro closed pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754266356
Hi, @michael-s-molina , thanks for the contribution! This looks great. I know this is probably too much to ask, but could you comment on each change on which errors/warnings they are supposed to solve if you still remember? PR review comments are fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754266356
Hi, @michael-s-molina , thanks for the contribution! This looks great. I know this is probably too much to ask, but could you comment on each change on which errors/warnings they are supposed to solve if you still remember?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.21%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 62.98% -3.22%
==========================================
Files 996 996
Lines 49174 49173 -1
Branches 4993 4996 +3
==========================================
- Hits 32554 30970 -1584
- Misses 16476 18003 +1527
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `64.22% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `64.28% <0.00%> (-29.70%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <ø> (-23.62%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `56.29% <63.33%> (-9.36%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `56.32% <75.00%> (-0.09%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.62% -2.59%
==========================================
Files 996 485 -511
Lines 49174 29797 -19377
Branches 4993 0 -4993
==========================================
- Hits 32554 18957 -13597
+ Misses 16476 10840 -5636
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.62% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.21%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 62.98% -3.22%
==========================================
Files 996 996
Lines 49174 49173 -1
Branches 4993 4996 +3
==========================================
- Hits 32554 30970 -1584
- Misses 16476 18003 +1527
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `64.22% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `64.28% <0.00%> (-29.70%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <ø> (-23.62%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `56.29% <63.33%> (-9.36%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `56.32% <75.00%> (-0.09%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **increase** coverage by `0.90%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
+ Coverage 66.20% 67.10% +0.90%
==========================================
Files 996 996
Lines 49174 49187 +13
Branches 4993 4996 +3
==========================================
+ Hits 32554 33008 +454
+ Misses 16476 16056 -420
+ Partials 144 123 -21
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.29% <15.90%> (+7.19%)` | :arrow_up: |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `64.22% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `92.85% <0.00%> (-1.12%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `87.50% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.22% <63.33%> (-3.43%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `72.15% <75.00%> (+15.74%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [64 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.56% -2.64%
==========================================
Files 996 485 -511
Lines 49174 29797 -19377
Branches 4993 0 -4993
==========================================
- Hits 32554 18940 -13614
+ Misses 16476 10857 -5619
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.56% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [505 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (6cf6acc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 63.99% -2.21%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19091 -13463
+ Misses 16476 10739 -5737
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.99% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.58% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | | |
| ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...6cf6acc](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754266356
Could you comment on each change on which errors/warnings they are supposed to solve if you still remember?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-753394931
thanks for the PRs @michael-s-molina! is there a test plan for them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#issuecomment-754003303
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=h1) Report
> Merging [#12213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=desc) (e4da213) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.56%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 62.63% -3.57%
==========================================
Files 996 996
Lines 49174 49173 -1
Branches 4993 4996 +3
==========================================
- Hits 32554 30801 -1753
- Misses 16476 18172 +1696
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.07% <60.41%> (-0.05%)` | :arrow_down: |
| python | `63.65% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `64.28% <0.00%> (-29.70%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (-6.05%)` | :arrow_down: |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `63.88% <ø> (-23.62%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.51% <20.00%> (-0.32%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `56.29% <63.33%> (-9.36%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `56.32% <75.00%> (-0.09%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.43% <100.00%> (+0.14%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `87.80% <100.00%> (ø)` | |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/12213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=footer). Last update [f3ab1f4...e4da213](https://codecov.io/gh/apache/incubator-superset/pull/12213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina commented on a change in pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#discussion_r552059329
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -138,41 +138,44 @@ const SubMenu: React.FunctionComponent<SubMenuProps> = props => {
props.tabs.map(tab => {
if ((props.usesRouter || hasHistory) && !!tab.usesRouter) {
return (
- <li
- className={tab.name === props.activeChild ? 'active' : ''}
- key={`${tab.label}`}
- >
- <div>
- <Link to={tab.url || ''}>{tab.label}</Link>
- </div>
- </li>
+ <React.Fragment key={`${tab.label}`}>
Review comment:
@ktmud Yes this fix the `activeHref` warning. I totally agree that we should migrate. This is already in my TODO list 😉. This will fix the warning until then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org