You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/01/08 23:59:20 UTC

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8886 )

Change subject: Add some DVLOG statements to help in debugging compaction issues
......................................................................


Patch Set 4:

(1 comment)

seems fine, but do you think these are useful enough to commit or were they one-offs for debugging this issue? it seems like enabling them outside of a unit test scenario would probably be so noisy as to be not useful

http://gerrit.cloudera.org:8080/#/c/8886/4/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:

http://gerrit.cloudera.org:8080/#/c/8886/4/src/kudu/tablet/compaction.cc@507
PS4, Line 507: 3
why's this one 3 instead of 4 like the rest?



-- 
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 4
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 08 Jan 2018 23:59:20 +0000
Gerrit-HasComments: Yes