[GitHub] [skywalking-banyandb-java-client] hanahmily commented on pull request #11: Truncate duration unit at days

[GitBox <gi...@apache.org>]

hanahmily commented on PR #11:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/11#issuecomment-1111598155

   I submitted https://github.com/apache/skywalking/issues/8965 to track this.
   
   On Wed, Apr 27, 2022 at 11:17 PM Jiajing LU ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java
   > <https://github.com/apache/skywalking-banyandb-java-client/pull/11#discussion_r859929047>
   > :
   >
   > > +                irRegistry.create(ir);
   > +            } catch (BanyanDBException ex) {
   > +                if (ex.getStatus().equals(Status.Code.ALREADY_EXISTS)) {
   > +                    continue;
   > +                }
   >
   > We have a series of getXXX to check this.
   >
   > BTW, we can't avoid this exception under a concurrent creating scenario
   > even get the resource before creating it. I tend to leave this piece as it
   > is and add a getting operation before the creating.
   >
   > IIRC getXXX will throw NOT_FOUND now if no schema is found...We have to
   > check that exception too...
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/skywalking-banyandb-java-client/pull/11#discussion_r859929047>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAO6UWONKCT4OQWJIZPN4ILVHFK7XANCNFSM5UNSOVCA>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***
   > com>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org