You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Alexei Scherbakov (JIRA)" <ji...@apache.org> on 2017/11/29 08:30:01 UTC
[jira] [Updated] (IGNITE-7049) Optimistic transaction is not
properly rolled back if timed out before sending prepare response.
[ https://issues.apache.org/jira/browse/IGNITE-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Scherbakov updated IGNITE-7049:
--------------------------------------
Description:
The test below hangs. Interestingly, it won't hang if no cache reference is acquired on client.
{noformat}
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.ignite.internal.processors.cache.transactions;
import org.apache.ignite.Ignite;
import org.apache.ignite.cluster.ClusterNode;
import org.apache.ignite.configuration.CacheConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
import org.apache.ignite.internal.TestRecordingCommunicationSpi;
import org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareResponse;
import org.apache.ignite.internal.util.typedef.G;
import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.apache.ignite.transactions.Transaction;
import static org.apache.ignite.cache.CacheAtomicityMode.TRANSACTIONAL;
import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
import static org.apache.ignite.transactions.TransactionConcurrency.OPTIMISTIC;
import static org.apache.ignite.transactions.TransactionIsolation.SERIALIZABLE;
/**
* Tests an ability to eagerly rollback timed out optimistic transactions.
*/
public class TxRollbackOnTimeoutOptimisticTest extends GridCommonAbstractTest {
/** */
private static final String CACHE_NAME = "test";
/** IP finder. */
private static final TcpDiscoveryVmIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true);
/** */
private static final int GRID_CNT = 3;
/** {@inheritDoc} */
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
((TcpDiscoverySpi)cfg.getDiscoverySpi()).setIpFinder(IP_FINDER);
TestRecordingCommunicationSpi commSpi = new TestRecordingCommunicationSpi();
cfg.setCommunicationSpi(commSpi);
boolean client = "client".equals(igniteInstanceName);
cfg.setClientMode(client);
if (!client) {
CacheConfiguration ccfg = new CacheConfiguration(CACHE_NAME);
ccfg.setAtomicityMode(TRANSACTIONAL);
ccfg.setBackups(2);
ccfg.setWriteSynchronizationMode(FULL_SYNC);
cfg.setCacheConfiguration(ccfg);
}
return cfg;
}
/**
* @return Near cache flag.
*/
protected boolean nearCacheEnabled() {
return false;
}
/** {@inheritDoc} */
@Override protected void beforeTest() throws Exception {
super.beforeTest();
startGridsMultiThreaded(GRID_CNT);
}
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
super.afterTest();
stopAllGrids();
}
/** */
public void testOptimisticTimeout() throws Exception {
final Ignite client = startGrid("client");
assertNotNull(client.cache(CACHE_NAME));
final ClusterNode n0 = client.affinity(CACHE_NAME).mapKeyToNode(0);
final Ignite prim = G.ignite(n0.id());
for (Ignite ignite : G.allGrids()) {
if (ignite == prim)
continue;
final TestRecordingCommunicationSpi spi =
(TestRecordingCommunicationSpi)ignite.configuration().getCommunicationSpi();
spi.blockMessages(GridDhtTxPrepareResponse.class, prim.name());
}
final int val = 0;
try {
multithreaded(new Runnable() {
@Override public void run() {
try (Transaction txOpt = client.transactions().txStart(OPTIMISTIC, SERIALIZABLE, 300, 1)) {
client.cache(CACHE_NAME).put(val, val);
txOpt.commit();
}
}
}, 1, "tx");
fail();
}
catch (Exception e) {
// No-op.
}
startGrid(GRID_CNT);
awaitPartitionMapExchange();
}
}
{noformat}
was:
Reproducer:
{noformat}
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.ignite.internal.processors.cache.transactions;
import org.apache.ignite.Ignite;
import org.apache.ignite.cluster.ClusterNode;
import org.apache.ignite.configuration.CacheConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
import org.apache.ignite.internal.TestRecordingCommunicationSpi;
import org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareResponse;
import org.apache.ignite.internal.util.typedef.G;
import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.apache.ignite.transactions.Transaction;
import static org.apache.ignite.cache.CacheAtomicityMode.TRANSACTIONAL;
import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
import static org.apache.ignite.transactions.TransactionConcurrency.OPTIMISTIC;
import static org.apache.ignite.transactions.TransactionIsolation.SERIALIZABLE;
/**
* Tests an ability to eagerly rollback timed out optimistic transactions.
*/
public class TxRollbackOnTimeoutOptimisticTest extends GridCommonAbstractTest {
/** */
private static final String CACHE_NAME = "test";
/** IP finder. */
private static final TcpDiscoveryVmIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true);
/** */
private static final int GRID_CNT = 3;
/** {@inheritDoc} */
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
((TcpDiscoverySpi)cfg.getDiscoverySpi()).setIpFinder(IP_FINDER);
TestRecordingCommunicationSpi commSpi = new TestRecordingCommunicationSpi();
cfg.setCommunicationSpi(commSpi);
boolean client = "client".equals(igniteInstanceName);
cfg.setClientMode(client);
if (!client) {
CacheConfiguration ccfg = new CacheConfiguration(CACHE_NAME);
ccfg.setAtomicityMode(TRANSACTIONAL);
ccfg.setBackups(2);
ccfg.setWriteSynchronizationMode(FULL_SYNC);
cfg.setCacheConfiguration(ccfg);
}
return cfg;
}
/**
* @return Near cache flag.
*/
protected boolean nearCacheEnabled() {
return false;
}
/** {@inheritDoc} */
@Override protected void beforeTest() throws Exception {
super.beforeTest();
startGridsMultiThreaded(GRID_CNT);
}
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
super.afterTest();
stopAllGrids();
}
/** */
public void testOptimisticTimeout() throws Exception {
final Ignite client = startGrid("client");
assertNotNull(client.cache(CACHE_NAME));
final ClusterNode n0 = client.affinity(CACHE_NAME).mapKeyToNode(0);
final Ignite prim = G.ignite(n0.id());
for (Ignite ignite : G.allGrids()) {
if (ignite == prim)
continue;
final TestRecordingCommunicationSpi spi =
(TestRecordingCommunicationSpi)ignite.configuration().getCommunicationSpi();
spi.blockMessages(GridDhtTxPrepareResponse.class, prim.name());
}
final int val = 0;
try {
multithreaded(new Runnable() {
@Override public void run() {
try (Transaction txOpt = client.transactions().txStart(OPTIMISTIC, SERIALIZABLE, 300, 1)) {
client.cache(CACHE_NAME).put(val, val);
txOpt.commit();
}
}
}, 1, "tx");
fail();
}
catch (Exception e) {
// No-op.
}
startGrid(GRID_CNT);
awaitPartitionMapExchange();
}
}
{noformat}
> Optimistic transaction is not properly rolled back if timed out before sending prepare response.
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-7049
> URL: https://issues.apache.org/jira/browse/IGNITE-7049
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.3
> Reporter: Alexei Scherbakov
> Fix For: 2.4
>
>
> The test below hangs. Interestingly, it won't hang if no cache reference is acquired on client.
> {noformat}
> /*
> * Licensed to the Apache Software Foundation (ASF) under one or more
> * contributor license agreements. See the NOTICE file distributed with
> * this work for additional information regarding copyright ownership.
> * The ASF licenses this file to You under the Apache License, Version 2.0
> * (the "License"); you may not use this file except in compliance with
> * the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
> package org.apache.ignite.internal.processors.cache.transactions;
> import org.apache.ignite.Ignite;
> import org.apache.ignite.cluster.ClusterNode;
> import org.apache.ignite.configuration.CacheConfiguration;
> import org.apache.ignite.configuration.IgniteConfiguration;
> import org.apache.ignite.internal.TestRecordingCommunicationSpi;
> import org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareResponse;
> import org.apache.ignite.internal.util.typedef.G;
> import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
> import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
> import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
> import org.apache.ignite.transactions.Transaction;
> import static org.apache.ignite.cache.CacheAtomicityMode.TRANSACTIONAL;
> import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
> import static org.apache.ignite.transactions.TransactionConcurrency.OPTIMISTIC;
> import static org.apache.ignite.transactions.TransactionIsolation.SERIALIZABLE;
> /**
> * Tests an ability to eagerly rollback timed out optimistic transactions.
> */
> public class TxRollbackOnTimeoutOptimisticTest extends GridCommonAbstractTest {
> /** */
> private static final String CACHE_NAME = "test";
> /** IP finder. */
> private static final TcpDiscoveryVmIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true);
> /** */
> private static final int GRID_CNT = 3;
> /** {@inheritDoc} */
> @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
> IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
> ((TcpDiscoverySpi)cfg.getDiscoverySpi()).setIpFinder(IP_FINDER);
> TestRecordingCommunicationSpi commSpi = new TestRecordingCommunicationSpi();
> cfg.setCommunicationSpi(commSpi);
> boolean client = "client".equals(igniteInstanceName);
> cfg.setClientMode(client);
> if (!client) {
> CacheConfiguration ccfg = new CacheConfiguration(CACHE_NAME);
> ccfg.setAtomicityMode(TRANSACTIONAL);
> ccfg.setBackups(2);
> ccfg.setWriteSynchronizationMode(FULL_SYNC);
> cfg.setCacheConfiguration(ccfg);
> }
> return cfg;
> }
> /**
> * @return Near cache flag.
> */
> protected boolean nearCacheEnabled() {
> return false;
> }
> /** {@inheritDoc} */
> @Override protected void beforeTest() throws Exception {
> super.beforeTest();
> startGridsMultiThreaded(GRID_CNT);
> }
> /** {@inheritDoc} */
> @Override protected void afterTest() throws Exception {
> super.afterTest();
> stopAllGrids();
> }
> /** */
> public void testOptimisticTimeout() throws Exception {
> final Ignite client = startGrid("client");
> assertNotNull(client.cache(CACHE_NAME));
> final ClusterNode n0 = client.affinity(CACHE_NAME).mapKeyToNode(0);
> final Ignite prim = G.ignite(n0.id());
> for (Ignite ignite : G.allGrids()) {
> if (ignite == prim)
> continue;
> final TestRecordingCommunicationSpi spi =
> (TestRecordingCommunicationSpi)ignite.configuration().getCommunicationSpi();
> spi.blockMessages(GridDhtTxPrepareResponse.class, prim.name());
> }
> final int val = 0;
> try {
> multithreaded(new Runnable() {
> @Override public void run() {
> try (Transaction txOpt = client.transactions().txStart(OPTIMISTIC, SERIALIZABLE, 300, 1)) {
> client.cache(CACHE_NAME).put(val, val);
> txOpt.commit();
> }
> }
> }, 1, "tx");
> fail();
> }
> catch (Exception e) {
> // No-op.
> }
> startGrid(GRID_CNT);
> awaitPartitionMapExchange();
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)