You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/09/08 03:14:33 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #28388: Verify inventory finished before starting consistency check

sandynz opened a new pull request, #28388:
URL: https://github.com/apache/shardingsphere/pull/28388

   If consistency check is started before inventory stage done, then consistency check should fail, it's not necessary to do it, so forbid it to avoid starting it by mistake.
   
   Changes proposed in this pull request:
     - Verify inventory finished before starting consistency check
     - Persist inventory progress after inventory done. Make sure when user find job status reaches EXECUTE_INCREMENTAL_TASK, consistency check could be started
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 merged pull request #28388: Verify inventory finished before starting consistency check

Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 merged PR #28388:
URL: https://github.com/apache/shardingsphere/pull/28388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org