You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@continuum.apache.org by "Gwen Harold Autencio (JIRA)" <ji...@codehaus.org> on 2008/10/23 17:15:19 UTC
[jira] Created: (CONTINUUM-1941) Creating Local Repository accepts
invalid location
Creating Local Repository accepts invalid location
--------------------------------------------------
Key: CONTINUUM-1941
URL: http://jira.codehaus.org/browse/CONTINUUM-1941
Project: Continuum
Issue Type: Bug
Environment: ubuntu
Reporter: Gwen Harold Autencio
Create a local repository in continuum.
e.g.
/home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1941) Continuum should create
directory when adding a local repository
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=191795#action_191795 ]
Wendy Smoak commented on CONTINUUM-1941:
----------------------------------------
Creating the directory if it doesn't exist is fine with me if dist build is not enabled.
In the dist build case, currently the master passes the value for -Dmaven.local.repo to the agent.
If you haven't configured any local repos and assigned them to project groups, then it will just pass whatever the DEFAULT local repo is on the master. In my case today, it passed /opt/continuum-data/local-repository to a Windows agent where that directory didn't exist.
I'm not sure what you mean by keys or namespaces. The local repo is just a string, it's up to the admin to make sure each project group is assigned a local repo that makes sense for that project, and then the agent passes it along. There's no way for the master to know if that's a valid value, because it doesn't know which agent the project will eventually build on.
The local repo probably needs to be moved into the Build Environment. Right now it's configured at the Project Group level, and what happens if I want to build my project on two agents that need a different local repo value?
> Continuum should create directory when adding a local repository
> ----------------------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Improvement
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
> Fix For: Backlog
>
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1941) Continuum should create
directory when adding a local repository
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=191781#action_191781 ]
Brett Porter commented on CONTINUUM-1941:
-----------------------------------------
Wendy, that might indicative of a separate problem. I agree that creating the directory if it doesn't exist is a good idea. I would say in the dist. build case that local repositories need to be keyed by some ID, or namespaced by agent - the master can't hand a directory to the slave on its filesystem even if they are the same OS (that would likely be a security flaw on an open Continuum slave).
> Continuum should create directory when adding a local repository
> ----------------------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Improvement
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
> Fix For: Backlog
>
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-1941) Continuum should create directory
when adding a local repository
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak updated CONTINUUM-1941:
-----------------------------------
Fix Version/s: Future
Issue Type: Improvement (was: Bug)
Summary: Continuum should create directory when adding a local repository (was: Creating Local Repository accepts invalid location)
Converted into an improvement to create the directory at the time a local repository is added.
If the directory cannot be created, then display an error and do not add the repo to the list.
> Continuum should create directory when adding a local repository
> ----------------------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Improvement
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
> Fix For: Future
>
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-1941) Continuum should create directory
when adding a local repository
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak updated CONTINUUM-1941:
-----------------------------------
Fix Version/s: Reviewed
> Continuum should create directory when adding a local repository
> ----------------------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Improvement
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
> Fix For: Reviewed
>
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1941) Creating Local Repository
accepts invalid location
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=151706#action_151706 ]
Wendy Smoak commented on CONTINUUM-1941:
----------------------------------------
What was the error?
That location is not _necessarily_ invalid, if the user running Continuum has permission to create it. (Of course, it shouldn't be running as a user with that much permission. :) )
If it doesn't already exist, we could attempt to create the directory when the configuration for a new local repository is added, rather than waiting until build time.
Maven itself does not require that the local repo exist prior to executing a build, it just creates it at build time if it's missing. If the directory can't be created, you get something like:
[WARNING] repository metadata for: 'org.apache.maven.plugins' could not be retrieved from repository: central due to an error: Specified destination directory cannot be created: /Users/sldkfjs/sfsldkjfsdy/org/apache/maven/plugins
> Creating Local Repository accepts invalid location
> --------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Bug
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1941) Continuum should create
directory when adding a local repository
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=191798#action_191798 ]
Brett Porter commented on CONTINUUM-1941:
-----------------------------------------
This is now a separate issue, but I'm thinking the local repository needs to be configured on the slave side and master selects an available local repository there. Regardless of the actual solution I think passing paths is a bad idea.
> Continuum should create directory when adding a local repository
> ----------------------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Improvement
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
> Fix For: Backlog
>
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1941) Continuum should create
directory when adding a local repository
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=191763#action_191763 ]
Wendy Smoak commented on CONTINUUM-1941:
----------------------------------------
Consider how this would affect distributed builds, where you may need to define a local repository c:\Documents and Settings\... for use on a Windows build agent, even though the master is running on Linux. It would not be possible to create that directory on the Linux server, and you wouldn't want to.
I'm leaning towards marking this WONTFIX. You'll just get an error at build time if the repo dir can't be created or used. Thoughts?
> Continuum should create directory when adding a local repository
> ----------------------------------------------------------------
>
> Key: CONTINUUM-1941
> URL: http://jira.codehaus.org/browse/CONTINUUM-1941
> Project: Continuum
> Issue Type: Improvement
> Environment: ubuntu
> Reporter: Gwen Harold Autencio
> Fix For: Backlog
>
>
> Create a local repository in continuum.
> e.g.
> /home/user/askjdfklsdajfklsajdf/asfsadfsadfsdfsadfasf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira