You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/23 13:44:41 UTC

[GitHub] [airflow] uranusjr opened a new issue, #23867: Don’t prompt for 'breeze build-image'

uranusjr opened a new issue, #23867:
URL: https://github.com/apache/airflow/issues/23867

   ### Body
   
   Currently, running the (new) `breeze build-image` brings up two prompts if any of the meta files are outdated:
   
   ```
   $ breeze build-image
   Good version of Docker: 20.10.14.
   Good version of docker-compose: 2.5.1
   The following important files are modified in ./airflow since last time image was built:
   
    * setup.py
    * Dockerfile.ci
    * scripts/docker/common.sh
    * scripts/docker/install_additional_dependencies.sh
    * scripts/docker/install_airflow.sh
    * scripts/docker/install_airflow_dependencies_from_branch_tip.sh
    * scripts/docker/install_from_docker_context_files.sh
   
   Likely CI image needs rebuild
   
   Do you want to build the image (this works best when you have good connection and can take usually from 20 seconds to few minutes depending how old your image is)?
   Press y/N/q. Auto-select n in 10 seconds (add `--answer n` to avoid delay next time): y
   
   This might take a lot of time (more than 10 minutes) even if you havea good network connection. We think you should attempt to rebase first.
   
   But if you really, really want - you can attempt it. Are you really sure?
   Press y/N/q. Auto-select n in 10 seconds (add `--answer n` to avoid delay next time): y
   ```
   
   While the prompts are shown in good nature, they don’t really make sense for `build-image` since the user already gave an explicit answer by running `build-image`. They should be suppressed.
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk closed issue #23867: Don’t prompt for 'breeze build-image'

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #23867: Don’t prompt for 'breeze build-image'
URL: https://github.com/apache/airflow/issues/23867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #23867: Don’t prompt for 'breeze build-image'

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #23867:
URL: https://github.com/apache/airflow/issues/23867#issuecomment-1134824848

   Oh absolutely :). It's been like that in the old breeze :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org