You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2014/05/20 16:14:50 UTC

[jira] [Created] (STORM-328) Config.java and Utils.get{Int,Long} are not in sync for floating point

Robert Joseph Evans created STORM-328:
-----------------------------------------

             Summary: Config.java and Utils.get{Int,Long} are not in sync for floating point
                 Key: STORM-328
                 URL: https://issues.apache.org/jira/browse/STORM-328
             Project: Apache Storm (Incubating)
          Issue Type: Bug
    Affects Versions: 0.9.2-incubating, 0.9.1-incubating, 0.9.0.1
            Reporter: Robert Joseph Evans


For most numeric configuration values Config.java has a type of Number listed, but the values are parsed using Utils.getInt or Utils.getLong, which means if someone gave a floating point number it would pass the ConfigValidation, but would blow up when it is used.  This is most critical for values that Nimbus reads, but would be good to have them consistent everywhere.

We should also check that getInt works properly for numbers that are larger then would fit in an integer.

Either we need to update Utils to be more lenient when looking at doubles, or we need to make Config more strict, which may be difficult with the YAML and JSON parsing that happens, where ints are often converted into longs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)