You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/20 21:18:58 UTC
[GitHub] [accumulo] dlmarion opened a new pull request #1801: fixes #1574: remove stop / start of MAC because flushes are waiting for completion. Reduce number of tables created so test does not time out.
dlmarion opened a new pull request #1801:
URL: https://github.com/apache/accumulo/pull/1801
remove stop / start of MAC because flushes are waiting for completion. Reduce number of tables created so test does not time out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #1801: fixes #1574: remove stop / start of MAC because flushes are waiting for completion. Reduce number of tables created so test does not time out.
Posted by GitBox <gi...@apache.org>.
dlmarion merged pull request #1801:
URL: https://github.com/apache/accumulo/pull/1801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #1801: fixes #1574: remove stop / start of MAC because flushes are waiting for completion. Reduce number of tables created so test does not time out.
Posted by GitBox <gi...@apache.org>.
dlmarion commented on pull request #1801:
URL: https://github.com/apache/accumulo/pull/1801#issuecomment-731412675
@ericnewton - do you happen to remember anything about this test. Is it important that five tables are created? It seems that this is testing that we read from all the files that are created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1801: fixes #1574: remove stop / start of MAC because flushes are waiting for completion. Reduce number of tables created so test does not time out.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1801:
URL: https://github.com/apache/accumulo/pull/1801#issuecomment-739127286
@dlmarion Next time, please consider using a better format for your git log messages. Yours has an extremely long subject line and no body. Here's a good guide on formatting good git log messages: https://chris.beams.io/posts/git-commit/
In your case, using that guide, a good message might have been something similar to the following:
```
Fix #1574 Improve reliability of MetadataMaxFilesIT (#1801)
1. remove stop / start of MAC (unnecessary step)
2. reduce number of tables created (use fewer resources)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org