You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/19 14:31:36 UTC
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #265: [Feature] Update issue template
imbajin commented on code in PR #265:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/265#discussion_r853140210
##########
.github/ISSUE_TEMPLATE/feature_request.yml:
##########
@@ -1,15 +1,83 @@
-name: Feature request (新需求 / 功能)
-description: Give an idea for HugeGraph
-title: '[Feature] describe the new feature'
-labels:
- - feature
-
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Feature request
+description: Suggest an idea for hugegraph-toolchain
+title: "[Feature][Module Name] Feature title"
+labels: ["Feature"]
Review Comment:
we don't need use uppercase, the issue label is lowercase usually
##########
.github/ISSUE_TEMPLATE/feature_request.yml:
##########
@@ -1,15 +1,83 @@
-name: Feature request (新需求 / 功能)
-description: Give an idea for HugeGraph
-title: '[Feature] describe the new feature'
-labels:
- - feature
-
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
Review Comment:
we don't need add license in non-code files
##########
.github/ISSUE_TEMPLATE/feature_request.yml:
##########
@@ -1,15 +1,83 @@
-name: Feature request (新需求 / 功能)
-description: Give an idea for HugeGraph
-title: '[Feature] describe the new feature'
-labels:
- - feature
-
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Feature request
+description: Suggest an idea for hugegraph-toolchain
+title: "[Feature][Module Name] Feature title"
Review Comment:
consider keep the `tag` simplify for user friendly, the module name could be mentioned in title content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org