You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/13 09:43:21 UTC

[GitHub] [airflow] david30907d commented on a change in pull request #21542: (bigquery-hook): forgot to pass engine_kwargs in

david30907d commented on a change in pull request #21542:
URL: https://github.com/apache/airflow/pull/21542#discussion_r805308216



##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -163,6 +163,8 @@ def get_sqlalchemy_engine(self, engine_kwargs=None):
         :param engine_kwargs: Kwargs used in :func:`~sqlalchemy.create_engine`.
         :return: the created engine.
         """
+        if engine_kwargs is None:
+            engine_kwargs = {}

Review comment:
       copied this block from [DbAPI.py](https://github.com/apache/airflow/blob/b40dffa08547b610162f8cacfa75847f3c4ca364/airflow/hooks/dbapi.py#L91-L99)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org