[GitHub] rabbah commented on a change in pull request #3115: remove drag from PrimitiveActions, LoadBalancerService, and Scheduler

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3115: remove drag from PrimitiveActions, LoadBalancerService, and Scheduler
URL: https://github.com/apache/incubator-openwhisk/pull/3115#discussion_r157658208
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
 ##########
 @@ -188,11 +190,11 @@ class LoadBalancerService(config: WhiskConfig, instance: InstanceId, entityStore
     // in case of missing synchronization between n controllers in HA configuration the invoker queue can be overloaded
     // n-1 times and the maximal time for answering with active ack can be n times the action time (plus some overhead)
     loadBalancerData.putActivation(activationId, {
-      actorSystem.scheduler.scheduleOnce(timeout) {
+      val timeoutHandler = actorSystem.scheduler.scheduleOnce(timeout) {
         processCompletion(Left(activationId), transid, forced = true, invoker = invokerName)
       }
 
-      ActivationEntry(activationId, namespaceId, invokerName, Promise[Either[ActivationId, WhiskActivation]]())
+      (timeoutHandler, ActivationEntry(activationId, namespaceId, invokerName, Promise[Either[ActivationId, WhiskActivation]]()))
 
 Review comment:
   is it cleaner to stuff the `timeoutHandler` into the `ActivationEntry`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services