You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/09/15 12:20:23 UTC
[GitHub] [ofbiz-plugins] CharlesNereide opened a new pull request #64: Best selling category template translation
CharlesNereide opened a new pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64
Fixed:Create a missing label for best selling category template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#issuecomment-919970188
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] CharlesNereide commented on a change in pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
CharlesNereide commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r710957303
##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
<value xml:lang="zh">分配明细</value>
<value xml:lang="zh-TW">分配細項</value>
</property>
+ <property key="EcommerceBestSelling">
Review comment:
You can close this one.
Thank you for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] priyasharma1 commented on a change in pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
priyasharma1 commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r709767028
##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
<value xml:lang="zh">分配明细</value>
<value xml:lang="zh-TW">分配細項</value>
</property>
+ <property key="EcommerceBestSelling">
Review comment:
Hi @CharlesNereide, thanks for your contribution!
Can we change this key to "EcommercePopularCategories" instead, for consistency reasons?
You might notice this pattern in other labels too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] CharlesNereide closed pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
CharlesNereide closed pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] CharlesNereide commented on a change in pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
CharlesNereide commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r710957041
##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
<value xml:lang="zh">分配明细</value>
<value xml:lang="zh-TW">分配細項</value>
</property>
+ <property key="EcommerceBestSelling">
Review comment:
OK. I will propose a new PR from a new branch with more corrections on Best Selling template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#issuecomment-919970188
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] priyasharma1 commented on a change in pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
priyasharma1 commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r710840589
##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
<value xml:lang="zh">分配明细</value>
<value xml:lang="zh-TW">分配細項</value>
</property>
+ <property key="EcommerceBestSelling">
Review comment:
Thanks for the explanation, Charles!
I agree with your suggestion, updating the label to "Best Selling" would make more sense in reference to the context of the template.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#issuecomment-919972201
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#issuecomment-919972201
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] priyasharma1 commented on a change in pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
priyasharma1 commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r710961988
##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
<value xml:lang="zh">分配明细</value>
<value xml:lang="zh-TW">分配細項</value>
</property>
+ <property key="EcommerceBestSelling">
Review comment:
Hi @CharlesNereide, would you mind creating a ticket. It will help to track the effort effectively.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] CharlesNereide commented on a change in pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
CharlesNereide commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r709858522
##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
<value xml:lang="zh">分配明细</value>
<value xml:lang="zh-TW">分配細項</value>
</property>
+ <property key="EcommerceBestSelling">
Review comment:
At the beginning, that was my idea. But the template is called ShowBestSellingCategory.ftl, the screen is called showBestSellingCategory and the template is only for the category "Best Selling" (PCCT_BEST_SELL). So, for me, the label is dedicated to Best Selling category and it's better to spell the label according to its usage than to it spelling.
Moreover, I wanted change english label "Popular categories" by "Best selling". I think that "Popular categories" would be more efficient for the "Most popular" category (PCCT_MOST_POPULAR) for exemple.
But it's just my point of view ;).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #64: Best selling category template translation
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#issuecomment-921832299
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=64&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=64&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org