You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/04/17 21:22:17 UTC
Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko and Nate Cole.
Bugs: AMBARI-20774
https://issues.apache.org/jira/browse/AMBARI-20774
Repository: ambari
Description
-------
When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
STR:
- Install a cluster with ZK and Storm
-- ZK should be on all 3 hosts, Storm only on 2
- Upload a VDF for Storm only and distribute it
With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
- NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
- OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
- INSTALLING for all others (INSTALLED when forced)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6e08e7b
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java df1aa37
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
Diff: https://reviews.apache.org/r/58483/diff/1/
Testing
-------
PENDING...
Thanks,
Jonathan Hurley
Re: Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/
-----------------------------------------------------------
(Updated April 18, 2017, 2:14 p.m.)
Review request for Ambari, Dmytro Grinenko and Nate Cole.
Bugs: AMBARI-20774
https://issues.apache.org/jira/browse/AMBARI-20774
Repository: ambari
Description
-------
When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
STR:
- Install a cluster with ZK and Storm
-- ZK should be on all 3 hosts, Storm only on 2
- Upload a VDF for Storm only and distribute it
With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
- NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
- OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
- INSTALLING for all others (INSTALLED when forced)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9c54a9d
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java 2954f0d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
Diff: https://reviews.apache.org/r/58483/diff/2/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/
-----------------------------------------------------------
(Updated April 18, 2017, 2:05 p.m.)
Review request for Ambari, Dmytro Grinenko and Nate Cole.
Bugs: AMBARI-20774
https://issues.apache.org/jira/browse/AMBARI-20774
Repository: ambari
Description
-------
When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
STR:
- Install a cluster with ZK and Storm
-- ZK should be on all 3 hosts, Storm only on 2
- Upload a VDF for Storm only and distribute it
With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
- NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
- OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
- INSTALLING for all others (INSTALLED when forced)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 9c54a9d
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java 2954f0d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
Diff: https://reviews.apache.org/r/58483/diff/2/
Changes: https://reviews.apache.org/r/58483/diff/1-2/
Testing
-------
PENDING...
Thanks,
Jonathan Hurley
Re: Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/#review172158
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 17, 2017, 9:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58483/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 9:22 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-20774
> https://issues.apache.org/jira/browse/AMBARI-20774
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
>
> STR:
> - Install a cluster with ZK and Storm
> -- ZK should be on all 3 hosts, Storm only on 2
> - Upload a VDF for Storm only and distribute it
>
> With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
> - NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
> - OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
> - INSTALLING for all others (INSTALLED when forced)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6e08e7b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java df1aa37
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
>
>
> Diff: https://reviews.apache.org/r/58483/diff/1/
>
>
> Testing
> -------
>
> PENDING...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On April 17, 2017, 5:57 p.m., Alejandro Fernandez wrote:
> >
Thanks for the review. I'll fix the log statement and the comment.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/#review172140
-----------------------------------------------------------
On April 17, 2017, 5:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58483/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-20774
> https://issues.apache.org/jira/browse/AMBARI-20774
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
>
> STR:
> - Install a cluster with ZK and Storm
> -- ZK should be on all 3 hosts, Storm only on 2
> - Upload a VDF for Storm only and distribute it
>
> With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
> - NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
> - OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
> - INSTALLING for all others (INSTALLED when forced)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6e08e7b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java df1aa37
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
>
>
> Diff: https://reviews.apache.org/r/58483/diff/1/
>
>
> Testing
> -------
>
> PENDING...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/#review172140
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
Line 1250 (original), 1243 (patched)
<https://reviews.apache.org/r/58483/#comment245237>
Small typo
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
Lines 1269 (patched)
<https://reviews.apache.org/r/58483/#comment245238>
Technically, 3rd argument is the version instead of the repo
- Alejandro Fernandez
On April 17, 2017, 9:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58483/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 9:22 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-20774
> https://issues.apache.org/jira/browse/AMBARI-20774
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
>
> STR:
> - Install a cluster with ZK and Storm
> -- ZK should be on all 3 hosts, Storm only on 2
> - Upload a VDF for Storm only and distribute it
>
> With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
> - NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
> - OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
> - INSTALLING for all others (INSTALLED when forced)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6e08e7b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java df1aa37
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
>
>
> Diff: https://reviews.apache.org/r/58483/diff/1/
>
>
> Testing
> -------
>
> PENDING...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58483: Service Upgrade VDF Creates Host Version
Entries For All Hosts With INSTALLING
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/#review172191
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 17, 2017, 5:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58483/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-20774
> https://issues.apache.org/jira/browse/AMBARI-20774
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a VDF for a {{SERVICE}} upgrade targets only a subset of hosts in the cluster, there is a host version entry created for all hosts with the state of {{INSTALLING}}. This causes the web client to think that the installation is not complete and it prevents the upgrade button from displaying.
>
> STR:
> - Install a cluster with ZK and Storm
> -- ZK should be on all 3 hosts, Storm only on 2
> - Upload a VDF for Storm only and distribute it
>
> With the introduction of PATCH/SERVICE repositories, we need to properly set the host_version based on a variety of factors:
> - NOT_REQUIRED if the host has no versionable components or has no components targetted by the repository
> - OUT_OF_SYNC _only_ if the host is supposed to have the repository installed but is in MM
> - INSTALLING for all others (INSTALLED when forced)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 6e08e7b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java c961995
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b7cc4cd
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java df1aa37
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 5ef31b5
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463
>
>
> Diff: https://reviews.apache.org/r/58483/diff/1/
>
>
> Testing
> -------
>
> PENDING...
>
>
> Thanks,
>
> Jonathan Hurley
>
>