You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by vl...@apache.org on 2023/06/29 07:56:20 UTC

[jmeter] branch master updated: doc: reduce severity from error to info when logging "JavaFX is missing"

This is an automated email from the ASF dual-hosted git repository.

vladimirsitnikov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new cf5b41f1e1 doc: reduce severity from error to info when logging "JavaFX is missing"
cf5b41f1e1 is described below

commit cf5b41f1e17fad19600826d2cff36bc4feaf4cf9
Author: Vladimir Sitnikov <si...@gmail.com>
AuthorDate: Thu Jun 29 10:56:05 2023 +0300

    doc: reduce severity from error to info when logging "JavaFX is missing"
---
 .../LogAndIgnoreServiceLoadExceptionHandler.java       | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/jorphan/src/main/java/org/apache/jorphan/reflect/LogAndIgnoreServiceLoadExceptionHandler.java b/src/jorphan/src/main/java/org/apache/jorphan/reflect/LogAndIgnoreServiceLoadExceptionHandler.java
index 5959bb54cc..edec94c6b6 100644
--- a/src/jorphan/src/main/java/org/apache/jorphan/reflect/LogAndIgnoreServiceLoadExceptionHandler.java
+++ b/src/jorphan/src/main/java/org/apache/jorphan/reflect/LogAndIgnoreServiceLoadExceptionHandler.java
@@ -33,11 +33,19 @@ public class LogAndIgnoreServiceLoadExceptionHandler implements ServiceLoadExcep
     public void handle(Class<?> service, String className, Throwable throwable) {
         if (throwable instanceof NoClassDefFoundError) {
             if (throwable.getMessage().contains("javafx")) {
-                log.error(
-                        "Exception registering implementation: [{}] of interface: [{}], a dependency used by the plugin class is missing. " +
-                                "Add JavaFX to your Java installation if you want to use renderer: {}",
-                        className, service, className, throwable
-                );
+                if (log.isDebugEnabled()) {
+                    log.debug(
+                            "Unable to load class {} for interface {}. The class depends on JavaFX which is missing in the current JVM. " +
+                                    "Use JVM distribution with JavaFX, or add it as a library for the class to work",
+                            className, service, throwable
+                    );
+                } else {
+                    log.info(
+                            "Class {} depends on JavaFX which is missing in the current JVM. " +
+                                    "Use JVM distribution with JavaFX, or add it as a library for the class to work",
+                            className
+                    );
+                }
             } else {
                 log.error(
                         "Exception registering implementation: [{}] of interface: [{}], a dependency used by the plugin class is missing",